Skip to content

Add specific wording and feedback options for not-explicitly-allowed pages#149

Merged
jon-betts merged 1 commit into
mainfrom
allow-list-error-page
Jan 21, 2021
Merged

Add specific wording and feedback options for not-explicitly-allowed pages#149
jon-betts merged 1 commit into
mainfrom
allow-list-error-page

Conversation

@jon-betts
Copy link
Copy Markdown
Contributor

@jon-betts jon-betts commented Jan 15, 2021

For: #15

There's clearly some debate to be had here, but this ensures that not-explicitly-allowed pages have very similar wording and feedback options to the current Via solution with the following exceptions:

Email content:

  • Instead of filling out the email saying that the user would like to annotate, we give them an opportunity to explain why they want the page unblocked instead without putting words in their mouths
  • This gives the user an opportunity to reveal that they aren't interested in annotation / don't know we do annotation etc.
  • I doubt this will happen often, but it seems worth a try
  • My best guess is people will just fire it off without editing it (this might be information all by itself)
  • In the future we might want to capture things like the browser type etc to help with decisions

Request for feedback:

  • This has slightly different wording to the deployed page, mostly to show we can
  • Now there are specific variations for each major type, it's probably time to pass over to front-end folk for any further design etc.
  • The call to action for emailing us is only shown on pages where the cause is not-explicitly-allowed
    • This matches the previous behaviour for previous categories
    • Importantly it doesn't encourage the user to request things we can't grant (publisher blocked pages)
    • ... or things we won't grant (pages we have actively chosen to block).

If we want to allow people to report mistakes in our active (rather than passive) blocking, I think that's a separate task and may have different requirements.

Testing notes

Not explicitly allowed:

http://localhost:9099/ui/block?url=http%3A%2F%2Fwabblewabble.com%2Fpath%3Fa%3D2&reason=not-explicitly-allowed&v=1&sec=bbb39e8f8f600a3c200feab3fc753afaa98f00ac4be4de2155f34beb330dd4c8

Malicious:

http://localhost:9099/ui/block?url=http%3A%2F%2Fbad.web.app&reason=malicious&v=1&sec=c13e01c72eaa510e28c35efec05eb608805f8ad27bf93730e77e07f2e125d483

Other:

http://localhost:9099/ui/block?url=http%3A%2F%2Fwww.youtube.com&reason=other&v=1&sec=142d0a1c44d84ac346ab2ee328f654958ec16a0bd5e85bea73f2d4ad3062a306

Publisher blocked:

http://localhost:9099/ui/block?url=http%3A%2F%2Fnautil.us&reason=publisher-blocked&v=1&sec=bdcefa4c2325326289d69d0844a7ac60b27a8603dd87d6c2dcede71e0c0e643c

@seanh
Copy link
Copy Markdown
Contributor

seanh commented Jan 19, 2021

@jon-betts Could you add some test URLs for the different versions of the page?

@jon-betts jon-betts force-pushed the central-error-pages branch 2 times, most recently from ac2ba81 to 2a8e449 Compare January 20, 2021 13:27
Base automatically changed from central-error-pages to main January 20, 2021 13:40
@jon-betts jon-betts force-pushed the allow-list-error-page branch from 0c0fc65 to df58d06 Compare January 20, 2021 17:16
@seanh
Copy link
Copy Markdown
Contributor

seanh commented Jan 21, 2021

I think there's an issue with the mailto link, random * in there (and the actual URL is missing):

Screenshot from 2021-01-21 12-28-15

Copy link
Copy Markdown
Contributor

@seanh seanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but the mailto link is broken (see above)

@jon-betts
Copy link
Copy Markdown
Contributor Author

Oops. I mean, we have excellent support people. I'm sure their psychic powers will suffice

@jon-betts
Copy link
Copy Markdown
Contributor Author

It's a rebase mistake. The variable changed name from url_to_annotate -> blocked_url in another PR

Also only prompt for feedback on those sites.
@jon-betts jon-betts force-pushed the allow-list-error-page branch from df58d06 to cd7dea0 Compare January 21, 2021 12:56
@jon-betts jon-betts requested a review from seanh January 21, 2021 12:56
@jon-betts
Copy link
Copy Markdown
Contributor Author

I've fixed the rebase error in this one, and also made the mailto link open in a new tab, as this was bugging me for some reason. I don't think sending an email feels like a browser navigation to the user so much as a separate action.

@jon-betts jon-betts merged commit 94492da into main Jan 21, 2021
@jon-betts jon-betts deleted the allow-list-error-page branch January 21, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants