Add specific wording and feedback options for not-explicitly-allowed pages#149
Merged
Conversation
6 tasks
Contributor
|
@jon-betts Could you add some test URLs for the different versions of the page? |
ac2ba81 to
2a8e449
Compare
0c0fc65 to
df58d06
Compare
Contributor
seanh
suggested changes
Jan 21, 2021
Contributor
seanh
left a comment
There was a problem hiding this comment.
Looks fine but the mailto link is broken (see above)
Contributor
Author
|
Oops. I mean, we have excellent support people. I'm sure their psychic powers will suffice |
Contributor
Author
|
It's a rebase mistake. The variable changed name from |
Also only prompt for feedback on those sites.
df58d06 to
cd7dea0
Compare
Contributor
Author
|
I've fixed the rebase error in this one, and also made the mailto link open in a new tab, as this was bugging me for some reason. I don't think sending an email feels like a browser navigation to the user so much as a separate action. |
seanh
approved these changes
Jan 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

For: #15
There's clearly some debate to be had here, but this ensures that
not-explicitly-allowedpages have very similar wording and feedback options to the current Via solution with the following exceptions:Email content:
Request for feedback:
not-explicitly-allowedIf we want to allow people to report mistakes in our active (rather than passive) blocking, I think that's a separate task and may have different requirements.
Testing notes
Not explicitly allowed:
http://localhost:9099/ui/block?url=http%3A%2F%2Fwabblewabble.com%2Fpath%3Fa%3D2&reason=not-explicitly-allowed&v=1&sec=bbb39e8f8f600a3c200feab3fc753afaa98f00ac4be4de2155f34beb330dd4c8
Malicious:
http://localhost:9099/ui/block?url=http%3A%2F%2Fbad.web.app&reason=malicious&v=1&sec=c13e01c72eaa510e28c35efec05eb608805f8ad27bf93730e77e07f2e125d483
Other:
http://localhost:9099/ui/block?url=http%3A%2F%2Fwww.youtube.com&reason=other&v=1&sec=142d0a1c44d84ac346ab2ee328f654958ec16a0bd5e85bea73f2d4ad3062a306
Publisher blocked:
http://localhost:9099/ui/block?url=http%3A%2F%2Fnautil.us&reason=publisher-blocked&v=1&sec=bdcefa4c2325326289d69d0844a7ac60b27a8603dd87d6c2dcede71e0c0e643c