A pretty rough and ready way of updating the allow list#213
Merged
Conversation
jon-betts
commented
Mar 4, 2021
| "result", | ||
| ] | ||
|
|
||
| class Row(list): |
Contributor
Author
There was a problem hiding this comment.
I really just want a mutable namedtuple. I think Python 3.8 data classes might be what I want?
marcospri
reviewed
Mar 9, 2021
|
|
||
| .PHONY: allow-list | ||
| allow-list: | ||
| @tox -qe dev --run-command 'python bin/add_to_allow_list.py' |
Contributor
There was a problem hiding this comment.
I added $(args) at the end locally to test all the scripts options
marcospri
approved these changes
Mar 9, 2021
Contributor
marcospri
left a comment
There was a problem hiding this comment.
Run the script locally, got my sql back and parse executed that and got
----+------------------------------------------------------------------+-------------------------+-------+----------
11 | ba531a147260901a82122006e8d4087535061d6e8cdcc38f0b498d09092f9846 | parishhillcreamery.com/ | f | {manual}
12 | 8629e9bd820962b996a7d7b87474ddb7940a24164bcc95c0772ddcd5153f4f42 | alimg.github.io/ | f | {manual}
13 | 6cc172ad9e7af2023a5f5c2f307c56dfd90debab7bb24b1c1cf675cf6b527a86 | thaipbsworld.com/ | f | {manual}
14 | 547f36b64bada557f35c8bfb41adb76bb52fee3509b53ca4a03a159ceac480a6 | hymnsandchants.com/ | f | {manual}
15 | 00f20fe539a81d3c30969bcc73d876322c8dd1ce8182ec3bb7e9e8717c4ab1e0 | noeldemartin.social/ | f | {manual}
16 | 68ebd205ce9805d33dd5ede44c215c240fa4e0c0082ff62ce91a12c012ef5d68 | kihealthandwellness.ca/ | f | {manual}
17 | 574f623bf1960aef32a32d5f5398de6f265564ea3afc2bf8d76d96c07fc676bb | garlandmag.com/ | f | {manual}
18 | 14fdc6f5ecce65a60ebff2a1d1f36777619373bf1b6e6675ee65f4117cd8fd55 | nosokomeiokalamatas.gr/ | f | {manual}
19 | ccf40ea589873e1c95c26eb3f8bfbe8be943a58c0d0665824afac4a225526dbb | phnci.org/ | f | {manual}
so all looks good 👍
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For: #195
Review notes
I was thinking this would end up with something we could have tests for, but honestly all the interesting stuff here already does and we just re-use it. I'm not sure testing would add much.
I was also hoping we could re-use some of this for the pages, but we won't. It's all very this CSV procedure specific:
The script does accept arguments if you pass them, but for convenience with
make(which has a quite lame way of passing arguments) I thought it was easier to just have a convention instead.Testing notes
Github doesn't allow CSV for some reason, so you'll need to rename this:
allow_list.csv.txt
allow_list.csvmake allow-listallow_list.done.csvwith results for giving feedback to supportallow_list.sqlwhich we can upload to