Skip to content

Conversation

@robertknight
Copy link
Contributor

@robertknight robertknight commented Aug 20, 2025

When a checkbox or radio button had a label that filled the entire available width, the icon would begin to shrink and would be clipped. The icon had a preferred size set, but not a minimum size.

Set the minimum size to match the SVG, which means 16px.

Part of a fix for hypothesis/h#9635. With the changes on this branch, the signup form looks like:

With fix

(The issue suggests aligning the checkbox with the baseline of the label, that's not implemented yet)


Testing:

On http://localhost:4001/input-checkbox, edit the label text for any of the examples to fill an entire line. On main, this will cause the icon to shrink. On this branch it won't.

… long

When a checkbox or radio button had a label that filled the entire available
width, the icon would begin to shrink and would be clipped. The icon had a
preferred size set, but not a minimum size.

Set the minimum size to match the SVG, which means 16px.

Part of a fix for hypothesis/h#9635.
@robertknight robertknight requested a review from acelaya August 20, 2025 13:55
@codecov
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d62a57c) to head (a099439).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2067   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           71        71           
  Lines         1361      1361           
  Branches       509       509           
=========================================
  Hits          1361      1361           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@robertknight robertknight merged commit e8132da into main Aug 20, 2025
4 checks passed
@robertknight robertknight deleted the checkbox-icon-min-size branch August 20, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants