Prevent checkbox / radio button icon from being clipped when label is long #2067
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a checkbox or radio button had a label that filled the entire available width, the icon would begin to shrink and would be clipped. The icon had a preferred size set, but not a minimum size.
Set the minimum size to match the SVG, which means 16px.
Part of a fix for hypothesis/h#9635. With the changes on this branch, the signup form looks like:
(The issue suggests aligning the checkbox with the baseline of the label, that's not implemented yet)
Testing:
On http://localhost:4001/input-checkbox, edit the label text for any of the examples to fill an entire line. On
main, this will cause the icon to shrink. On this branch it won't.