Render lazy-loaded components synchronously if already loaded #2074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make lazy-loading components created by `lazy` render synchronously (ie. render the actual component on the first render) if the component was already loaded by a previous instance of the lazy wrapper component. In h the async rendering was causing annotation cards to transition their height slightly after appearing. This change doesn't prevent the animation from happening when annotation cards first appear, but does prevent it on subsequen renders.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2074 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 1361 1364 +3
Branches 509 509
=========================================
+ Hits 1361 1364 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
acelaya
reviewed
Aug 28, 2025
robertknight
added a commit
to hypothesis/h
that referenced
this pull request
Aug 28, 2025
This is a partial fix for an issue where annotation card heights change slightly after the first render. See hypothesis/frontend-shared#2074.
robertknight
added a commit
to hypothesis/h
that referenced
this pull request
Aug 28, 2025
This is a partial fix for an issue where annotation card heights change slightly after the first render. See hypothesis/frontend-shared#2074.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make lazy-loading components created by
lazyrender synchronously (ie. render the actual component on the first render) if the component was already loaded by a previous instance of the lazy wrapper component.In h the async rendering was causing annotation cards to transition their height slightly after appearing. This change doesn't prevent the animation from happening when annotation cards first appear, but does prevent it on subsequent renders.