Replace focus-ring-visible usage with Tailwind's built-in equivalent #2083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace uses of our custom `focus-ring-visible` utility with Tailwind's built-in equivalent styles (`focus-ring:visible focus-ring:outline-none`). The original reason for our custom utility was to support a polyfill for `:focus-visible`, but we no longer need/use that polyfill. This looks the same as before but will be easier to migrate to Tailwind v4. In Tailwind v3 `outline-none` doesn't actually generate `outline-style: none`, but the result is equivalent for our purposes. See https://tailwindcss.com/docs/upgrade-guide#renamed-outline-utility. The focus-ring-visible plugin is still included in the package because downstream apps are still using it. We can remove it after the same migration is applied there.
robertknight
force-pushed
the
focus-visible-ring
branch
from
2e9b8e7 to
e3fd59d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2083 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 1364 1364
Branches 509 509
=========================================
Hits 1364 1364 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
acelaya
approved these changes
Sep 10, 2025
robertknight
added a commit
to hypothesis/h
that referenced
this pull request
Sep 10, 2025
- Update Tailwind dependencies - Convert forms.scss to a "plain" CSS file. This avoids the SASS compiler trying to preprocess the Tailwind imports. - Update @hypothesis/annotation-ui for hypothesis/annotation-ui#87 - Update @hypothesis/frontend-build for Tailwind v4 support - Update @hypothesis/frontend-shared for hypothesis/frontend-shared#2083
robertknight
added a commit
to hypothesis/h
that referenced
this pull request
Sep 10, 2025
- Update Tailwind dependencies - Convert forms.scss to a "plain" CSS file. This avoids the SASS compiler trying to preprocess the Tailwind imports. - Update @hypothesis/annotation-ui for hypothesis/annotation-ui#87 - Update @hypothesis/frontend-build for Tailwind v4 support - Update @hypothesis/frontend-shared for hypothesis/frontend-shared#2083
robertknight
added a commit
to hypothesis/h
that referenced
this pull request
Sep 10, 2025
- Update Tailwind dependencies - Convert forms.scss to a "plain" CSS file. This avoids the SASS compiler trying to preprocess the Tailwind imports. - Update @hypothesis/annotation-ui for hypothesis/annotation-ui#87 - Update @hypothesis/frontend-build for Tailwind v4 support - Update @hypothesis/frontend-shared for hypothesis/frontend-shared#2083
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace uses of our custom
focus-ring-visibleutility with Tailwind's built-in equivalent styles (focus-ring:visible focus-ring:outline-none). The original reason for our custom utility was to support a polyfill for:focus-visible, but we no longer need/use that polyfill.This looks the same as before but will be easier to migrate to Tailwind v4. In Tailwind v3
outline-nonedoesn't actually generateoutline-style: none, but the result is equivalent for our purposes. Seehttps://tailwindcss.com/docs/upgrade-guide#renamed-outline-utility.
The focus-ring-visible plugin is still included in the package because downstream apps are still using it. We can remove it after the same migration is applied there.