Migrate pattern library site and tests to Tailwind v4 #2084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertknight
commented
Sep 10, 2025
| stickyHeaderHeight, | ||
| scrollEl.scrollTop, | ||
| 1, | ||
| 2, |
Contributor
Author
There was a problem hiding this comment.
Expected height is 50, actual height before was 49 but is now 48.
robertknight
commented
Sep 10, 2025
| // But when in a Panel, and the Panel is within a height-constrained | ||
| // element, the total Panel height will not exceed parent height (200px) | ||
| assert.equal( | ||
| assert.isBelow( |
Contributor
Author
There was a problem hiding this comment.
Actual value is now 198, which matches the test description of being below 200.
robertknight
force-pushed
the
tailwind-v4
branch
from
047a5a5 to
bd762b5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2084 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 1364 1364
Branches 509 509
=========================================
Hits 1364 1364 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
robertknight
force-pushed
the
tailwind-v4
branch
from
bd762b5 to
499d04b
Compare
Migrate the pattern library website and tests to use Tailwind v4. The npm package remains usable with either Tailwind v3 or v4 downstream. The changes here are similar to those in h (hypothesis/h#9877).
robertknight
force-pushed
the
tailwind-v4
branch
from
499d04b to
a30d0a7
Compare
acelaya
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the pattern library website and tests to use Tailwind v4. The npm package remains usable with either Tailwind v3 or v4 downstream. The changes here are similar to those in h (hypothesis/h#9877).