Redirect to Checkmate error pages#43
Merged
Merged
Conversation
6 tasks
6ad6b87 to
fe16d58
Compare
seanh
approved these changes
Jan 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For: hypothesis/checkmate#15
This removes ViaHTML's own error pages and instead relies on whatever Checkmate tells us to show to people. We do a temporary redirect there for the moment, as we don't have any indication of how long the block should last for.
This cannot be merged until checkmatelib has been updated with: hypothesis/checkmatelib#5. The version number in the requirements is therefore a guess.
Testing notes
git checkout add-html-viewmake services devrequirements.txtto replace the checkmatelib line with-e ../checkmatelibmake devbad.example.cominstead)