Better sdr eotf settings #12812
Open
Better sdr eotf settings #12812
+117
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Changes global and per-monitor TF settings to a enum to avoid confusion and allows setting global to sRGB and per-monitor to gamma22 (previously this exact combo wasn't possible)
defaultor0- HL default, currently gamma22auto- for global same as default, monitor uses globalgamma22or1- gamma22gamma22forceor2- global gamma22 and remap srgb to gamma22, monitor - gamma22srgbor3- srgbIs there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Legacy numeric values and values meant for one of the settings only won't be mentioned in the wiki.
Configs with
render:cm_sdr_eotf = 3andmonitorv2:sdr_eotf = 0(or unset) should be changed to usemonitorv2:sdr_eotf = srgbif this is the desired setting (probably not)Is it ready for merging, or does it need work?
Ready