refactor: enhance popup detection with intelligent polling mechanism #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the popup detection mechanism in the browser initialization flow to use an intelligent polling approach instead of sequential checks with long hard-coded timeouts, significantly improving browser launch performance.
Changes:
- Replaced sequential popup detection (with up to 35s total timeout) with a unified polling loop that checks all popup types in parallel with a maximum 6-second duration
- Introduced early exit logic based on consecutive idle iterations to minimize wait time when no popups are present
- Consolidated popup configuration into a structured array for better maintainability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bbbugg
force-pushed
the
backup/fast-browser
branch
from
0753260 to
e225843
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch browser faster.
启动浏览器更快。