Open
Conversation
Owner
|
Hey @cruse1977, Thank you for the great PR! I'm currently testing this in my dev environment. A few points I came across already:
FROM netboxcommunity/netbox:latest
COPY ./phonebox_plugin /source/phonebox_plugin/phonebox_plugin/
COPY ./pyproject.toml /source/phonebox_plugin/
COPY ./MANIFEST.in /source/phonebox_plugin/
COPY ./README.md /source/phonebox_plugin/
RUN /usr/local/bin/uv pip install --no-cache-dir /source/phonebox_plugin/
|
Author
|
Sure, will do |
|
any chance this will be merged soon? |
|
I too am wondering when we think this will be merged. Are there issues? How likely is it to be merged? |
brourk
added a commit
to brourk/phonebox_plugin
that referenced
this pull request
Feb 20, 2026
This release merges key improvements from upstream PR iDebugAll#57 and adds comprehensive export functionality. Major Changes: - Migrated models from ChangeLoggedModel to NetBoxModel - Added site field to Number model - Enabled CSV export and Export Template support - Updated for NetBox 4.2.0 through 4.9.x compatibility - Removed legacy version checking code Model Updates: - Number and VoiceCircuit now inherit from NetBoxModel - Added optional site field to Number (ForeignKey to dcim.Site) - Updated csv_headers to include site - Updated get_absolute_url() to use new URL names Forms & Filters: - Added site field to all Number forms (Filter, Edit, BulkEdit, CSV) - Updated NumberFilterSet to include site filtering - Simplified imports by removing conditional version checks Views & URLs: - Removed all version detection logic - Standardized template names for NetBox 4.x - Updated URL patterns with backward compatibility aliases API: - Added site field to NumberSerializer - Maintained nested serializer pattern for consistency Export Functionality: - CSV export automatically enabled via ObjectListView - Export Template support via NetBoxModel inheritance - Both Number and VoiceCircuit appear in /extras/export-templates/ Database: - Added migration 0005_add_site_to_number.py Documentation: - Created CLAUDE.md for AI assistant guidance - Updated setup.py with new version and Python 3.10-3.12 Fixes: - Issue iDebugAll#55, iDebugAll#59: Export functionality implemented - Issue iDebugAll#15: Site field added to Number model - Issue iDebugAll#47: Permission fixes from upstream 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the plugin significantly.
Tested against NetBox 4.2.3 (Docker)