Skip to content

fix: make sync-link repo selection deterministic for e2e#55

Merged
iHildy merged 4 commits intoian/add-turso-session-backendfrom
ian/deterministic-sync-link-e2e
Apr 13, 2026
Merged

fix: make sync-link repo selection deterministic for e2e#55
iHildy merged 4 commits intoian/add-turso-session-backendfrom
ian/deterministic-sync-link-e2e

Conversation

@iHildy
Copy link
Copy Markdown
Owner

@iHildy iHildy commented Apr 12, 2026

Summary

  • make sync-link deterministic in E2E by seeding an explicit machine-B repo instruction at session start
  • add test-only strict link mode to disable auto-discovery and enforce an exact expected repo during E2E
  • extend repo parsing to support owner/name and GitHub URL/SSH formats for explicit link targets
  • update sync-link command guidance and add repo parsing tests

Validation

  • bun run check
  • bun test
  • bun run build
  • E2E baseline flow passed with strict link repo enforcement
  • Full Turso E2E rerun passed:

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a "strict link" mode and the ability to disable repository auto-discovery, primarily for E2E testing. It adds environment variable support to enforce specific repository targets and implements a parseRepoReference utility to handle GitHub repository identifiers in HTTP, SSH, and short-name formats. Review feedback suggests enhancing the robustness of the parsing logic by supporting ssh:// protocols, allowing optional trailing slashes in SSH strings, and adding validation to the generic owner/repo parser to prevent false positives from malformed input.

Comment thread src/sync/repo.ts
Comment thread src/sync/repo.ts Outdated
Comment thread src/sync/repo.ts
@jules-relay
Copy link
Copy Markdown

jules-relay bot commented Apr 12, 2026

🤖 Review Jules Relay

I found 1 Gemini suggestion so far.

Type /relay batch to send all suggestions to Jules.

@iHildy iHildy self-assigned this Apr 13, 2026
@iHildy iHildy merged commit 2b3c496 into ian/add-turso-session-backend Apr 13, 2026
3 checks passed
iHildy added a commit that referenced this pull request Apr 13, 2026
* feat: add Turso session backend with setup and migration commands

* fix: make sync-link repo selection deterministic for e2e (#55)

* fix: make sync-link repo selection deterministic for e2e

* fix: harden turso runtime session sync safety

* fix: harden repo reference parsing for PR feedback

* refactor: reduce turso sync io overhead

* fix: harden turso session sync transport and timeouts
iHildy added a commit that referenced this pull request Apr 13, 2026
* fix: expand e2e coverage and docs for session sync compatibility

* feat: add Turso session backend for concurrent-safe sync (#54)

* feat: add Turso session backend with setup and migration commands

* fix: make sync-link repo selection deterministic for e2e (#55)

* fix: make sync-link repo selection deterministic for e2e

* fix: harden turso runtime session sync safety

* fix: harden repo reference parsing for PR feedback

* refactor: reduce turso sync io overhead

* fix: harden turso session sync transport and timeouts

* fix: avoid mutating string values when parsing JSONC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant