Make sure DetTypes are defined#146
Merged
andresailer merged 1 commit intomasterfrom Apr 17, 2026
Merged
Conversation
Otherwise laoding will fail after AIDASoft/DD4hep#1578 because the exception that was previously silently swallowed no longer is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise laoding will fail after
AIDASoft/DD4hep#1578 because the exception that was previously silently swallowed no longer is
BEGINRELEASENOTES
DetTypes are defined in the CLIC visualization geometry to avoid failing to load the geometry with newer versions of DD4hepENDRELEASENOTES