Skip to content

Improve reboot function and better response validation #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iMicknl merged 1 commit into from
Jun 8, 2024
Merged

Improve reboot function and better response validation #312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sagemcom_api/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,8 @@ def __get_response_value(self, response, index=0):
value = self.__get_response(response, index)["value"]
except KeyError:
value = None
except IndexError:
value = None

# Rewrite result to snake_case
value = humps.decamelize(value)
Expand Down Expand Up @@ -420,6 +422,7 @@ async def get_port_mappings(self) -> list[PortMapping]:
async def reboot(self):
"""Reboot Sagemcom F@st device."""
action = {
"id": 0,
"method": "reboot",
"xpath": "Device",
"parameters": {"source": "GUI"},
Expand Down