Bug fix/estimate hours by Sreddx · Pull Request #2 · iNBest-cloud/Azure-devops-cli-tool

Sreddx · 2025-11-10T15:35:36Z

No description provided.

- Introduced `AGENTS.md` to outline project structure, build commands, coding style, testing guidelines, and commit practices. - Updated `OPTIMIZED_USAGE_EXAMPLES.md` with new usage examples reflecting recent changes in work item queries. - Added `user_email_mapping.json` for mapping user names to emails. - Created `workitemsoctober.json` to store work item data for October. - Enhanced `efficiency_calculator.py` and `WorkItemOperations.py` to preserve exact Logic App estimates by disabling certain adjustments. - Updated `IMPLEMENTATION_ANALYSIS.md` to document intentional changes and their impact on efficiency metrics.

…tion - Introduced `.env.example` to provide a template for environment variables, including Azure DevOps organization and Logic App URL. - Added `LOGIC_APP_MIGRATION.md` to document the migration from WIQL/Analytics API to Azure Logic App for work item data retrieval. - Implemented `LogicAppClient` for fetching work items based on date ranges and user emails, enhancing the efficiency of data retrieval. - Updated `WorkItemOperations` to utilize the Logic App client, removing legacy WIQL methods and simplifying the querying process. - Enhanced efficiency calculations to incorporate Logic App estimates directly, improving accuracy in productivity metrics. - Added email mapping utilities to resolve user names to email addresses for querying work items. - Updated main entry point to reflect new command structure and required arguments for Logic App integration.

Copilot

Pull Request Overview

This pull request introduces a significant architectural change by migrating from WIQL/Analytics API-based work item fetching to Azure Logic App with Fabric Data Warehouse as the primary data source. The refactoring aims to simplify the workflow and centralize work item data retrieval.

Key Changes:

Adds Logic App integration with new helper modules for HTTP client, email resolution, timezone utilities, and environment configuration
Updates CLI to require --start-date and --end-date arguments, making the Logic App flow the default for work item queries
Includes comprehensive migration documentation and configuration templates

Reviewed Changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 20 comments.

Show a summary per file

File	Description
user_email_mapping.json	New configuration file mapping developer names to email addresses for Logic App queries
helpers/timezone_utils.py	New utility module for Mexico City timezone conversions and date boundary calculations
helpers/logic_app_client.py	New HTTP client for Logic App with retry logic and exponential backoff
helpers/env_loader.py	New environment variable loader with validation for required configuration
helpers/email_mapping.py	New utility for resolving user names/emails from mapping file
helpers/init.py	New package initialization file for helpers module
entry_points/main.py	Updated CLI to use Logic App as default, with legacy arguments marked for compatibility
classes/efficiency_calculator.py	Updated to use exact Logic App estimates with documentation about disabled transformations
classes/WorkItemOperations.py	Added new method `get_work_items_from_logic_app()` implementing the Logic App workflow
documentation/IMPLEMENTATION_ANALYSIS.md	Added documentation about intentionally disabled estimate transformations
config/azure_devops_config.json	Updated default developers list to match current team
OPTIMIZED_USAGE_EXAMPLES.md	Updated usage example with new developer name
LOGIC_APP_MIGRATION.md	New comprehensive migration guide documenting the architectural change
AGENTS.md	New repository guidelines for contributors
.env.example	New environment configuration template with Logic App URL

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-10T15:43:46Z

helpers/timezone_utils.py

+    """
+    mx_dt = convert_utc_to_mexico_city(dt)
+    return mx_dt.strftime("%Y-%m-%d %H:%M:%S %Z")


The docstring states the return format as "YYYY-MM-DD HH:MM:SS CST/CDT" but the actual format uses %Z which will output the timezone abbreviation as determined by the system. For America/Mexico_City, this could be "CST" or "CDT" depending on daylight saving time, but it's not guaranteed to match the documented format. Consider clarifying the documentation or using a more explicit format string.

Suggested change

"""

mx_dt = convert_utc_to_mexico_city(dt)

return mx_dt.strftime("%Y-%m-%d %H:%M:%S %Z")

The timezone abbreviation is determined by the UTC offset:

- CST for UTC-6 (standard time)

- CDT for UTC-5 (daylight saving time)

"""

mx_dt = convert_utc_to_mexico_city(dt)

# Mexico City: UTC-6 is CST, UTC-5 is CDT

offset_hours = mx_dt.utcoffset().total_seconds() / 3600

if offset_hours == -6:

tz_abbr = "CST"

elif offset_hours == -5:

tz_abbr = "CDT"

else:

tz_abbr = mx_dt.strftime("%Z") # fallback, should not happen

return mx_dt.strftime("%Y-%m-%d %H:%M:%S ") + tz_abbr

Copilot · 2025-11-10T15:43:46Z

LOGIC_APP_MIGRATION.md

+    "Table1": [
+      {
+        "WorkItemId": 42964,
+        "AssignedToUser": "Carlos Vazquez",


The example shows "AssignedToUser": "Carlos Vazquez" but based on the code in helpers/email_mapping.py and user_email_mapping.json, this field should contain an email address, not a name. The example should be corrected to show "AssignedToUser": "carlos.vazquez@inbest.cloud" to match the actual expected format.

Suggested change

"AssignedToUser": "Carlos Vazquez",

"AssignedToUser": "carlos.vazquez@inbest.cloud",

Copilot · 2025-11-10T15:43:47Z

classes/WorkItemOperations.py

+        - StartDate: Start date
+        - TargetDate: Target date
+        - OriginalEstimate: Estimated hours
+        - Project_Name: Azure DevOps project name (REQUIRED for revision fetching)


The docstring states "Project_Name: Azure DevOps project name (REQUIRED for revision fetching)" but the code below (lines 1397-1398) sets these fields to None if project_name is empty, rather than raising an error. The documentation should clarify whether this field is truly required or if it's optional with a fallback behavior.

Copilot · 2025-11-10T15:43:47Z

classes/WorkItemOperations.py

+        if items_without_project > 0:
+            print(f"   ⚠️  Warning: {items_without_project} work items missing Project_Name")
+            print(f"   These items will be skipped for efficiency calculations")
+            print(f"   Please ensure Logic App returns 'Project_Name' field for all work items")


The warning message "⚠️ Warning: {items_without_project} work items missing Project_Name" uses an underscore in "Project_Name", but the field might be more clearly referenced in user-facing messages without the underscore (e.g., "Project Name" or "'Project_Name' field"). Consider making the field reference clearer for users who may not be familiar with the internal field naming.

Suggested change

print(f" Please ensure Logic App returns 'Project_Name' field for all work items")

print(f" Please ensure Logic App returns the Project Name for all work items")

Copilot · 2025-11-10T15:43:47Z

entry_points/main.py

    Handle work item querying with dynamic filtering and KPI calculations.
+
+    NEW DEFAULT: Uses Logic App for work item fetching.
+    Legacy WIQL/Analytics method removed per refactoring requirements.


The comment states "NEW DEFAULT: Uses Logic App for work item fetching" and "Legacy WIQL/Analytics method removed", but looking at the broader codebase context, the old method get_work_items_with_efficiency_optimized still exists (line 1522 onwards in WorkItemOperations.py). The comment should clarify that the legacy method still exists but is no longer used by the CLI, or the method should actually be removed if it's truly deprecated.

Suggested change

Legacy WIQL/Analytics method removed per refactoring requirements.

Note: The legacy WIQL/Analytics method (`get_work_items_with_efficiency_optimized`) still exists in the codebase but is no longer used by the CLI.

Copilot · 2025-11-10T15:43:51Z

OPTIMIZED_USAGE_EXAMPLES.md

-python run.py --query-work-items --assigned-to "Luis Nocedal,Carlos Vazquez,Diego Lopez,Alejandro Valenzuela,Gerardo Melgoza,Hans Izarraraz,Osvaldo de Luna,Uriel Cortés,Emmanuel Pérez,Fernando Alcaraz,Damian Gaspar,Cristian Soria,Daniel Cayola,Ximena Segura, Andrés Escobedo, Alvaro Torres, Pablo Ruiz, Sebastián Rojas, Fernando Hernández" --start-date "2025-09-01" --end-date "2025-09-30" --optimized --export-csv "september_results.csv"
+python run.py --query-work-items --assigned-to "Luis Nocedal,Carlos Vazquez,Diego Lopez,Alejandro Valenzuela,Gerardo Melgoza,Hans Izarraraz,Osvaldo de Luna,Uriel Cortés,Emmanuel Pérez,Fernando Alcaraz,Damian Gaspar,Cristian Soria,Daniel Cayola,Ximena Segura, Andrés Escobedo, Alvaro Torres, Pablo Ruiz, Sebastián Rojas, Fernando Hernández, Daniel Reyes" --start-date "2025-10-01" --end-date "2025-10-31" --optimized --export-csv "october_test_hours.csv"

 python run.py --query-work-items --assigned-to "Luis Nocedal,Carlos Vazquez,Diego Lopez,Alejandro Valenzuela,Gerardo Melgoza,Hans Izarraraz,Osvaldo de Luna,Uriel Cortés,Emmanuel Pérez,Fernando Alcaraz,Damian Gaspar,Cristian Soria,Daniel Cayola,Ximena Segura, Andrés Escobedo, Alvaro Torres, Pablo Ruiz, Sebastián Rojas, Fernando Hernández, Daniel Reyes" --start-date "2025-09-01" --end-date "2025-09-30" --optimized --export-csv "september_results_final.csv"


This example command still uses the legacy --optimized flag. According to the migration guide and CLI changes, the new Logic App flow doesn't require this flag. The example should be updated to match the new workflow.

Copilot · 2025-11-10T15:43:51Z

user_email_mapping.json

@@ -0,0 +1,22 @@
+{
+    "Luis Nocedal": "luis.nodecal@inbest.cloud",


Spelling error in email address: "nodecal" should be "nocedal" to match the user's name "Luis Nocedal".

Suggested change

"Luis Nocedal": "luis.nodecal@inbest.cloud",

"Luis Nocedal": "luis.nocedal@inbest.cloud",

Copilot · 2025-11-10T15:43:51Z

classes/WorkItemOperations.py

+                'original_estimate': item.get('OriginalEstimate'),
+                'fabric_enriched': True,
+                'revisions': [],
+                'project_id': project_name if project_name else None,  # Use project name as identifier


Using project_name as the value for project_id is confusing and could lead to bugs. The field name project_id suggests it should contain an ID, not a name. Consider either renaming the field to project_identifier or storing the actual project ID if available.

Suggested change

'project_id': project_name if project_name else None, # Use project name as identifier

'project_identifier': project_name if project_name else None, # Use project name as identifier

Copilot · 2025-11-10T15:43:52Z

classes/WorkItemOperations.py

 from datetime import datetime, timedelta
 import json
-from typing import List, Dict, Optional, Any
+from typing import List, Dict, Optional, Any, Tuple


Import of 'Any' is not used.

Suggested change

from typing import List, Dict, Optional, Any, Tuple

from typing import List, Dict, Optional, Tuple

Copilot · 2025-11-10T15:43:52Z

helpers/logic_app_client.py

+import requests
+import logging
+import time
+from typing import List, Dict, Any, Optional


Import of 'Optional' is not used.

Suggested change

from typing import List, Dict, Any, Optional

from typing import List, Dict, Any

Sreddx added 2 commits November 5, 2025 13:23

Copilot AI review requested due to automatic review settings November 10, 2025 15:35

Sreddx merged commit 156759b into master Nov 10, 2025
4 checks passed

Sreddx deleted the bug-fix/estimate-hours branch November 10, 2025 15:38

Copilot AI reviewed Nov 10, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug fix/estimate hours#2

Bug fix/estimate hours#2
Sreddx merged 2 commits intomasterfrom
bug-fix/estimate-hours

Sreddx commented Nov 10, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 10, 2025

Uh oh!

Copilot AI Nov 10, 2025

Uh oh!

Copilot AI Nov 10, 2025

Uh oh!

Copilot AI Nov 10, 2025

Uh oh!

Copilot AI Nov 10, 2025

Uh oh!

Copilot AI Nov 10, 2025

Uh oh!

Copilot AI Nov 10, 2025

Uh oh!

Copilot AI Nov 10, 2025

Uh oh!

Copilot AI Nov 10, 2025

Uh oh!

Copilot AI Nov 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

-    """
-    mx_dt = convert_utc_to_mexico_city(dt)
-    return mx_dt.strftime("%Y-%m-%d %H:%M:%S %Z")
+        The timezone abbreviation is determined by the UTC offset:
+        - CST for UTC-6 (standard time)
+        - CDT for UTC-5 (daylight saving time)
+    """
+    mx_dt = convert_utc_to_mexico_city(dt)
+    # Mexico City: UTC-6 is CST, UTC-5 is CDT
+    offset_hours = mx_dt.utcoffset().total_seconds() / 3600
+    if offset_hours == -6:
+        tz_abbr = "CST"
+    elif offset_hours == -5:
+        tz_abbr = "CDT"
+    else:
+        tz_abbr = mx_dt.strftime("%Z")  # fallback, should not happen
+    return mx_dt.strftime("%Y-%m-%d %H:%M:%S ") + tz_abbr

	"AssignedToUser": "Carlos Vazquez",
	"AssignedToUser": "carlos.vazquez@inbest.cloud",

	print(f" Please ensure Logic App returns 'Project_Name' field for all work items")
	print(f" Please ensure Logic App returns the Project Name for all work items")

	Legacy WIQL/Analytics method removed per refactoring requirements.
	Note: The legacy WIQL/Analytics method (`get_work_items_with_efficiency_optimized`) still exists in the codebase but is no longer used by the CLI.

		@@ -0,0 +1,22 @@
		{
		"Luis Nocedal": "luis.nodecal@inbest.cloud",

	"Luis Nocedal": "luis.nodecal@inbest.cloud",
	"Luis Nocedal": "luis.nocedal@inbest.cloud",

	'project_id': project_name if project_name else None, # Use project name as identifier
	'project_identifier': project_name if project_name else None, # Use project name as identifier

	from typing import List, Dict, Optional, Any, Tuple
	from typing import List, Dict, Optional, Tuple

	from typing import List, Dict, Any, Optional
	from typing import List, Dict, Any

Conversation

Sreddx commented Nov 10, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant