-
-
Notifications
You must be signed in to change notification settings - Fork 80
expansion animations #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expansion animations #169
Conversation
|
SettingsExpander Expand/Collapse animations |
7f11b24 to
49b70df
Compare
|
@NotYoojun can u take a look at this, please? |
NotYoojun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your good work! However, there are a few problems that need to be resolved before merging. The most important one is how the animation impacts the layout.
Outer Layout
As you can see, when expanding a CommunityToolkit expander, the component will take the space immediately, and in this PR, the space grows along the animation.
Current behavior in this PR:
Expected behavior in CommunityToolkit:
Inner Layout
What's more, the content in the Expander doesn't seems to be arranged correctly.
Current behavior:
Expected behavior:
I have to apologize that the GIFs may not be clear and easy enough to understand. You can download the CommunityToolkit Gallery from Microsoft Store, and you'll feel the actual differences.
Incorrect Duration
Additionally, the duration of this animation seems to be incorrect.
Please make sure that everything is the exact same as native Windows UI or CommunityToolkit. We're be so appreciated if you could fix these problems above. Thanks!
NotYoojun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Well done! We really appreciate your dedication to open source. Your contribution is valuable to us and the community. Keep up the great work! |
|
By the way, this closes #127 |
Thank you. |







No description provided.