Skip to content

Conversation

@mou-haz
Copy link
Contributor

@mou-haz mou-haz commented Jun 28, 2025

fix #186

update numberbox style to match winui.

@GID0317
Copy link
Contributor

GID0317 commented Jul 2, 2025

Hi,
its look good now, thank you! But look like the selected background brush seems missing and the chevron icon seems need to be a little bit smaller like in WinUI image bellow
Current:
image
image
image

WinUI:
Screenshot 2025-07-02 123919
image
image

@mou-haz
Copy link
Contributor Author

mou-haz commented Jul 3, 2025

i think it's good now

@GID0317
Copy link
Contributor

GID0317 commented Jul 3, 2025

Hi, thank you its look great now

@Jack251970
Copy link
Contributor

Look great!

@mou-haz mou-haz changed the title fix number box [STYLE] NumberBox Jul 11, 2025
@NotYoojun NotYoojun self-requested a review August 31, 2025 09:49
Copy link
Member

@NotYoojun NotYoojun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update - the styling improvements are looking good overall. However, I’ve noticed two regressions compared to WinUI’s behavior that should be addressed before merging:

  1. Inline placement: When the NumberBox is using SpinButtonPlacementMode="Inline", the up/down buttons do not show a hover effect when the control is not focused. In WinUI, these buttons still respond visually to hover regardless of focus state.

  2. Compact placement: When the NumberBox is using SpinButtonPlacementMode="Compact", the up/down buttons do not have a hover effect at all. In WinUI, they should always show the hover visual when the pointer is over them.

Both of these cases should match WinUI’s interaction behavior for consistency and usability. Could you update the control template/visual states so that the hover effect is applied in these scenarios?

If you’d prefer not to make these changes yourself, I may consider implementing them later - but I can’t promise when, as my schedule is currently quite busy.

@mou-haz
Copy link
Contributor Author

mou-haz commented Sep 3, 2025

@NotYoojun , you are welcome ,
Thanks for the pr review.
The hover state should be working like winui now.

@NotYoojun NotYoojun merged commit 3778def into iNKORE-NET:main Sep 21, 2025
1 check passed
@Jack251970
Copy link
Contributor

@mou-haz @NotYoojun After this update (0.10.2.1), the style of NumberBox cannot be applied automatically. I think the problem is from this PR.

image

@Jack251970
Copy link
Contributor

More information in Flow-Launcher/Flow.Launcher#4201

@mou-haz mou-haz mentioned this pull request Jan 5, 2026
@mou-haz
Copy link
Contributor Author

mou-haz commented Jan 5, 2026

Hey @Jack251970 , can u see if the PR works for you ?

@Jack251970
Copy link
Contributor

Hey @Jack251970 , can u see if the PR works for you ?

It looks pretty difficult to me. I need to clone your PR repository and use this repository in Flow Launcher. Will try later

@mou-haz
Copy link
Contributor Author

mou-haz commented Jan 5, 2026

Hey @Jack251970 , can u see if the PR works for you ?

It looks pretty difficult to me. I need to clone your PR repository and use this repository in Flow Launcher. Will try later

I tried to test a fork locally using the new changes. can you take a look at it?

numberBox.mp4

@Jack251970
Copy link
Contributor

@mou-haz Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] The number box style did not match the style of WinUI

4 participants