-
-
Notifications
You must be signed in to change notification settings - Fork 80
[STYLE] NumberBox #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[STYLE] NumberBox #268
Conversation
|
i think it's good now |
|
Hi, thank you its look great now |
|
Look great! |
NotYoojun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update - the styling improvements are looking good overall. However, I’ve noticed two regressions compared to WinUI’s behavior that should be addressed before merging:
-
Inline placement: When the
NumberBoxis usingSpinButtonPlacementMode="Inline", the up/down buttons do not show a hover effect when the control is not focused. In WinUI, these buttons still respond visually to hover regardless of focus state. -
Compact placement: When the
NumberBoxis usingSpinButtonPlacementMode="Compact", the up/down buttons do not have a hover effect at all. In WinUI, they should always show the hover visual when the pointer is over them.
Both of these cases should match WinUI’s interaction behavior for consistency and usability. Could you update the control template/visual states so that the hover effect is applied in these scenarios?
If you’d prefer not to make these changes yourself, I may consider implementing them later - but I can’t promise when, as my schedule is currently quite busy.
|
@NotYoojun , you are welcome , |
|
@mou-haz @NotYoojun After this update (0.10.2.1), the style of NumberBox cannot be applied automatically. I think the problem is from this PR.
|
|
More information in Flow-Launcher/Flow.Launcher#4201 |
|
Hey @Jack251970 , can u see if the PR works for you ? |
It looks pretty difficult to me. I need to clone your PR repository and use this repository in Flow Launcher. Will try later |
I tried to test a fork locally using the new changes. can you take a look at it? numberBox.mp4 |
|
@mou-haz Sure! |







fix #186
update numberbox style to match winui.