Skip to content

Conversation

@mou-haz
Copy link
Contributor

@mou-haz mou-haz commented Jul 1, 2025

fix #261
updated navigationview resources from
NavigationView_themeresources.xaml

fix iNKORE-NET#261
updated navigationview resources from
NavigationView_themeresources.xaml
@Valkirie
Copy link
Contributor

Valkirie commented Jul 1, 2025

You've been doing an amazing job lately. Thank you very much.

@mou-haz
Copy link
Contributor Author

mou-haz commented Jul 1, 2025

You are welcome 😄😄

@NotYoojun NotYoojun self-requested a review July 2, 2025 01:55
Copy link
Member

@NotYoojun NotYoojun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your great work!

There's just one more thing I noticed, the padding of NavigationViewItem seems different:

iUWM:

image

Windows UI:

image

Would you like to look into this problem? or simply ignore it and go on?

@GID0317
Copy link
Contributor

GID0317 commented Jul 2, 2025

Hi,

Overall, it's already good! Unfortunately, when I tested it the selected brush seems to be still missing the hover effect like on the images bellow:
image

on winui its like this:
image

@mou-haz
Copy link
Contributor Author

mou-haz commented Jul 2, 2025

Hi, thanks for your great work!

There's just one more thing I noticed, the padding of NavigationViewItem seems different:

iUWM:

image

Windows UI:

image

Would you like to look into this problem? or simply ignore it and go on?

ok, i will look into it.

updated top navigation view item styles
@mou-haz
Copy link
Contributor Author

mou-haz commented Jul 2, 2025

i think the top navigation view style is now similar to winui one

TopNavigationViewComparsion-PO_PR.mp4

@GID0317
i couldn't trigger the state you are mentioning in winui gallery, can u please provide a way to get it ?

winuiTop.mp4

@mou-haz mou-haz requested a review from NotYoojun July 2, 2025 23:21
@GID0317
Copy link
Contributor

GID0317 commented Jul 3, 2025

i think the top navigation view style is now similar to winui one

TopNavigationViewComparsion-PO_PR.mp4
@GID0317 i couldn't trigger the state you are mentioning in winui gallery, can u please provide a way to get it ?

winuiTop.mp4

Hi, sorry for late reply

that state was for when the child navigation is selected like in the video. but it's after retesting it seems like it's already working greats like on the video

Screen.Recording.2025-07-03.084947.mp4

@mou-haz
Copy link
Contributor Author

mou-haz commented Jul 3, 2025

No Problem,
Thanks for your efforts.

@NotYoojun NotYoojun merged commit 70f0123 into iNKORE-NET:main Oct 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] The top NavigationView mode was Missing hover brush unlike what the WinUI do

4 participants