-
-
Notifications
You must be signed in to change notification settings - Fork 80
[STYLE] Expander animations #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
NotYoojun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really a good idea to hardcide these values? Well at least I dont think so.
209914b to
e843ab9
Compare
e843ab9 to
08992f6
Compare
|
@NotYoojun , i think it now doesn't depend on hardcoded values. |
NotYoojun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TL;DR: Changes requested before we can merge
Thanks for your contribution! 🙌🏻
We've reviewed your pull request and it's a great step forward.
Before we can merge it, there are just a few things that would make it even better:
Corner Radius in Expanded State
The corner radius styling appears incorrect when the expander is expanded. I've attached images to illustrate the issue. Please review the visual styling and ensure consistency across states.
❌ Wrong (current)
✅ Correct
ExpanderDirection Compatibility
The current implementation only works correctly when ExpanderDirection == Down. If the direction is set to Left, Right, or Up, the layout breaks or behaves unexpectedly. Could you please update the logic to support all ExpanderDirection values?
When you have a chance, please update the PR with these refinements.
If anything is unclear or you'd like guidance, we're more than happy to help - just let us know.
If you don't have the time or energy to make these changes yourself, that's completely okay.
But please always say so openly, let us know, and our team or other contributors can step in to help finish it up if anyone is available.
|
@NotYoojun Thanks for the review. |
…UI.WPF.Modern into expander_animations_302
070e976 to
5328d0c
Compare
unnecessary changes
5328d0c to
c270e5d
Compare
Resolves #302
Resolves #319
Updated animations for exander card style.
Update animations for SettingsExpander Expander.