Skip to content

Conversation

@mou-haz
Copy link
Contributor

@mou-haz mou-haz commented Jul 19, 2025

Resolves #302
Resolves #319

Updated animations for exander card style.
Update animations for SettingsExpander Expander.

Copy link
Member

@NotYoojun NotYoojun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really a good idea to hardcide these values? Well at least I dont think so.

@mou-haz mou-haz force-pushed the expander_animations_302 branch from 209914b to e843ab9 Compare August 25, 2025 17:07
@mou-haz mou-haz requested a review from NotYoojun August 25, 2025 17:07
@mou-haz mou-haz force-pushed the expander_animations_302 branch from e843ab9 to 08992f6 Compare September 3, 2025 01:02
@mou-haz
Copy link
Contributor Author

mou-haz commented Sep 3, 2025

@NotYoojun , i think it now doesn't depend on hardcoded values.

Copy link
Member

@NotYoojun NotYoojun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR: Changes requested before we can merge

Thanks for your contribution! 🙌🏻

We've reviewed your pull request and it's a great step forward.
Before we can merge it, there are just a few things that would make it even better:


Corner Radius in Expanded State

The corner radius styling appears incorrect when the expander is expanded. I've attached images to illustrate the issue. Please review the visual styling and ensure consistency across states.

❌ Wrong (current)

Image

✅ Correct

Image

ExpanderDirection Compatibility

The current implementation only works correctly when ExpanderDirection == Down. If the direction is set to Left, Right, or Up, the layout breaks or behaves unexpectedly. Could you please update the logic to support all ExpanderDirection values?


When you have a chance, please update the PR with these refinements.
If anything is unclear or you'd like guidance, we're more than happy to help - just let us know.

If you don't have the time or energy to make these changes yourself, that's completely okay.
But please always say so openly, let us know, and our team or other contributors can step in to help finish it up if anyone is available.

@mou-haz
Copy link
Contributor Author

mou-haz commented Oct 5, 2025

@NotYoojun Thanks for the review.
The suggested changes have been implemented. can u take a look now?

@mou-haz mou-haz requested a review from NotYoojun October 5, 2025 02:26
@mou-haz mou-haz force-pushed the expander_animations_302 branch 2 times, most recently from 070e976 to 5328d0c Compare October 5, 2025 02:36
unnecessary changes
@mou-haz mou-haz force-pushed the expander_animations_302 branch from 5328d0c to c270e5d Compare October 5, 2025 02:42
@NotYoojun NotYoojun merged commit eda35bd into iNKORE-NET:main Oct 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] SettingsExpander IsExpanded="True" doesn't work correctly on load Expander Card-style missing animation unlike in WinUI

2 participants