Skip to content

Odd RTH and Manual mode behaviour during WP mission #6689

@breadoven

Description

@breadoven

Current Behaviour

If RTH mode or Manual mode is selected when flying a mission you end up locked in RTH mode until WP mode is deselected. This is a little confusing especially where Manual mode is concerned because you expect to regain full manual control in this situation not find yourself in a different automated Nav mode.

Steps to Reproduce

  1. Fly mission by selecting WP mode
  2. Select RTH mode or Manual mode - RTH activates
  3. Deselect RTH or Manual mode
  4. RTH remains active
  5. Deselect WP mode - RTH stops

Expected behaviour

Maintaining RTH until WP mode is deselected is understandable if RTH mode has been selected during a WP mission but the situation with Manual mode doesn't make sense. Seem to remember that pre 2.6.0 switching to Manual during a WP mission gave you Manual mode not RTH. Not sure why why this was changed, oversight or intended ?

Suggested solution(s)

The following needs to account for Manual mode being selected so it doesn't trigger RTH instead.

if (IS_RC_MODE_ACTIVE(BOXNAVRTH) || (IS_RC_MODE_ACTIVE(BOXNAVWP) && !canActivateWaypoint)) {

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions