-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Description
Current Behaviour
If RTH mode or Manual mode is selected when flying a mission you end up locked in RTH mode until WP mode is deselected. This is a little confusing especially where Manual mode is concerned because you expect to regain full manual control in this situation not find yourself in a different automated Nav mode.
Steps to Reproduce
- Fly mission by selecting WP mode
- Select RTH mode or Manual mode - RTH activates
- Deselect RTH or Manual mode
- RTH remains active
- Deselect WP mode - RTH stops
Expected behaviour
Maintaining RTH until WP mode is deselected is understandable if RTH mode has been selected during a WP mission but the situation with Manual mode doesn't make sense. Seem to remember that pre 2.6.0 switching to Manual during a WP mission gave you Manual mode not RTH. Not sure why why this was changed, oversight or intended ?
Suggested solution(s)
The following needs to account for Manual mode being selected so it doesn't trigger RTH instead.
inav/src/main/navigation/navigation.c
Line 3151 in 198b4f2
| if (IS_RC_MODE_ACTIVE(BOXNAVRTH) || (IS_RC_MODE_ACTIVE(BOXNAVWP) && !canActivateWaypoint)) { |