-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Set OSD Layout with global functions #5934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set OSD Layout with global functions #5934
Conversation
|
Great addition! Thanks @kernel-machine. Sadly there is a case when the GF (global function) wont work, not a bug just how its performing now. If the OSD layouts are activated in the MODE tab so that they can be selected with a switch, GF is unable to change the layout. I would have liked to have a certain OSD layout activating upon going into waypoint navigation but that does not work since all three OSD layouts are governed by the assigned switch. Only if the switch is in a position not driving the OSD mode, then GF can take over the OSD layout. |
It can be implemented for the next release, sincerely when I'm implemented this feature I haven't thought at the OSD layout modes, but this is an user preferences, someone prefer that LC override the OSD modes and someone prefers viceversa |
|
I have found it by coincidence. Unfortunately everyone who uses OSD modes has a selection through a channel which will prevent the GF from working. I am unsure how difficult it is to implement but I believe that might be the best scenario: -If OSD GF is True it overrides OSD Mode until False. That way during the triggering event OSD GF will be displayed unless the user manual selects an OSD Mode in which case OSD GF is no longer important until next time it is triggered. What do you think about? |
|
I'm not convinced for the second scenario
I must think about it |
I can see one flaw, it is when the OSD layout is only reachable through OSD GF but not through OSD Mode. If the user changes to OSD Mode he cannot come back to the initial layout unless recycling the OSD GF. In some cases thats not feasable, for example when the trigger is starting a WP mission, as recycling the OSD GF means restarting the mission. |
Added the ability to change OSD layout with global function.
It can be useful for example to show a layout with gps coordinates when the distance from home is major of a certain threshold, while a layout without GPS coordinates will be showed when the UAV is near.