Skip to content

[CMS] fix editing of negative servo weights#5980

Merged
digitalentity merged 1 commit intoiNavFlight:masterfrom
snaewe:sn/fix-cms-mixer-weight
Jul 25, 2020
Merged

[CMS] fix editing of negative servo weights#5980
digitalentity merged 1 commit intoiNavFlight:masterfrom
snaewe:sn/fix-cms-mixer-weight

Conversation

@snaewe
Copy link
Contributor

@snaewe snaewe commented Jul 24, 2020

The OSD/CMS doesn't allow correct editing of negative servo mixer weights.
The value can only be made larger (towards positive) but not smaller.
Fix that by setting the min. value for the weight to -1000.

This is based on release_2.5.2 to get it fixed ASAP.

@snaewe snaewe mentioned this pull request Jul 24, 2020
@digitalentity
Copy link
Member

Please rebase on master. I'll cherry-pick this to 2.5.2

@digitalentity digitalentity modified the milestones: 2.6, 2.5.2 Jul 24, 2020
The OSD/CMS doesn't allow correct editing of negative servo mixer weights.
The value can only be made larger (towards positive) but not smaller.
Fix that by setting the min. value for the weight to -1000.

Signed-off-by: Stefan Naewe <stefan.naewe@gmail.com>
@snaewe snaewe force-pushed the sn/fix-cms-mixer-weight branch from f15c9b7 to 9c1bc1a Compare July 25, 2020 08:52
@snaewe snaewe changed the base branch from release_2.5.2 to master July 25, 2020 08:54
@snaewe
Copy link
Contributor Author

snaewe commented Jul 25, 2020

Rebase onto master (17e559e)

@digitalentity digitalentity merged commit a41a4de into iNavFlight:master Jul 25, 2020
digitalentity added a commit that referenced this pull request Jul 25, 2020
[CMS] fix editing of negative servo weights
@snaewe snaewe deleted the sn/fix-cms-mixer-weight branch July 29, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants