[MAVLINK] Add new mavlink messages#6062
Merged
digitalentity merged 7 commits intoiNavFlight:masterfrom Oct 10, 2020
Merged
Conversation
digitalentity
requested changes
Aug 22, 2020
f451e16 to
178acd6
Compare
- Update throttle to also show auto thr
- send battery cell count and consumption in battery status
- send baro or imu temperature in scaled pressure sensor
- send osd system msg as status text
178acd6 to
55ab364
Compare
…for sending empty status text
Contributor
Author
|
Updated the PR. Please review and let me know if I can improve. Below is the full list of changes:
|
Contributor
Author
|
@digitalentity should I change anything to help the review process? |
Member
|
Sorry, this fell through the cracks. Will have a look later on today. |
digitalentity
approved these changes
Oct 6, 2020
Member
digitalentity
left a comment
There was a problem hiding this comment.
LGTM from me. @fiam can you have a second look at the changes in the OSD messages code?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi devs, this adds a new mavlink data stream at 1Hz. This is crucial to have system messages for systems such as OpenHD.
Please, let me know if I can improve this commit. The messages are based on OSD functions and a bit duplicated, but I saw no better way to avoid messing with the OSD.
If possible, let me know your thoughts about updating iNav to the new Mavlink v2 and also including some msgs from ardupilot dialect. That way we could send ESC temperatures and Wind estimation via Mavlink.