Add TPA to inflight adjustment (+ OSD element)#6242
Add TPA to inflight adjustment (+ OSD element)#6242digitalentity merged 1 commit intoiNavFlight:masterfrom
Conversation
| ADJUSTMENT_FW_MIN_THROTTLE_DOWN_PITCH_ANGLE = 48, | ||
| ADJUSTMENT_VTX_POWER_LEVEL = 49, | ||
| ADJUSTMENT_TPA = 50, | ||
| ADJUSTMENT_TPA_BREAKPOINT = 51, |
There was a problem hiding this comment.
Can we add it after "ADJUSTMENT_PROFILE " so that existing entries do not change id?
There was a problem hiding this comment.
Unfortunately no, the configurator generates the adjustments on the fly, so the ids have to be without a gap, and the inactive element ADJUSTMENT_PROFILE have to be the last.
There was a problem hiding this comment.
What is the way forward for this, as I am looking to add an adjustment also? It seems that if PROFILE_ADJUSTMENT can be inactive, there is no way it can maintain an ID, unless configurator treats adjustments like modes, and receives the IDs too.
There was a problem hiding this comment.
@DzikuVx @Scavanger I don't see ADJUSTMENT_PROFILE being handled anywhere in the code, so to me it looks like this was added to the list of the available adjustments in 0ca0163 and never actually implemented. I think it's safe to remove ADJUSTMENT_PROFILE altogether from both firmware and Configurator
There was a problem hiding this comment.
FYI, I did not see it in Configurator at all.
There was a problem hiding this comment.
I'm going to merge this and clean up the ADJUSTMENT_PROFILE in a subsequent PRs to firmware and Configurator.
4 participants
Duplicate of #6055, i had some problems with git, so i had to do a new PR:
This allows to tune Thrust PID Attenuation (TPA) and TPA Breakpoint via inflight adjustments.
Also adds an OSD Element that shows the values.
See #5965 and #5985
PR for configurator: iNavFlight/inav-configurator#1054