Skip to content

Adds DJI OSD support to 2x F3 boards#6279

Merged
digitalentity merged 1 commit intoiNavFlight:masterfrom
t413:f3-djiosd
Nov 10, 2020
Merged

Adds DJI OSD support to 2x F3 boards#6279
digitalentity merged 1 commit intoiNavFlight:masterfrom
t413:f3-djiosd

Conversation

@t413
Copy link
Contributor

@t413 t413 commented Nov 10, 2020

  • SPRACINGF3 and AIRHEROF3
  • both boards have no analog OSD hardware
  • (This patch works on master and 2.5.x)
  • Enables DJI-OSD without the menu CMS system since it can't be used with DJI anyway.
  • Actually REDUCES flash usage by 1%, ram usage by almost 5%.

Compiles nicely. Tested on both boards with DJI OSD. Configurable in the iNav Configurator.

Replaces #6262– seems there's a rule to merge from non-master branches only I want to do it right!

@t413
Adds DJI OSD support to 2x F3 boards
ea59b0e 
- SPRACINGF3 and AIRHEROF3
- both boards have no classic OSD
- This patch works on master and 2.5.x
@t413 t413 mentioned this pull request Nov 10, 2020
Closed
@t413
Copy link
Contributor Author

t413 commented Nov 10, 2020

I discussed this on telegram, and it seems unpopular to add any changes for F3 related targets since you're fazing them out. I understand. A few things to consider first!

  • This isn't a boutique target build. DJI FPV is getting super popular, seems lots of folks are asking for DJI FPV OSD. I don't even fly with it personally and was asked to help get it working for @evanrlee
  • These boards are super available and inexpensive! There's no equivalent F4 board with similar features but no analog OSD IC.
  • A commit to do this exact thing for another F3 board was merged on May 31st!
  • This patch actually REDUCES the flash usage by 1%! Down to 86.56%
    • This is because I also undef CMS_MENU_OSD which can't be used by this serial OSD anyway.
  • I think the potentially numerous DJI F3 pilots should come to your official impressive build/CI/release system for releases instead of having federated repos with builds from me.
    • Again, I don't even fly dji! this is just to help friends who do who wanted it.

@digitalentity digitalentity added this to the 2.6 milestone Nov 10, 2020
@digitalentity
Copy link
Member

digitalentity commented Nov 10, 2020

Merging. Even though 2.6 is likely to be the last milestone to support F3 CPUs, no reason to deprive the existing targets of this feature if it fits in memory.

@digitalentity digitalentity merged commit 381ac55 into iNavFlight:master Nov 10, 2020
@DzikuVx
Copy link
Member

DzikuVx commented Dec 3, 2020

we have to revert this change, causes SPRF3 not to boot after flashing 2.6-RC3
Looks like stack overflow problem

@DzikuVx
Copy link
Member

DzikuVx commented Dec 3, 2020

#6366

@t413
Copy link
Contributor Author

t413 commented Dec 3, 2020 •
edited
Loading

Ahh that's too bad, wonder what else changed that caused this since it worked on 2.5 up through builds made a week ago.

Thanks for letting me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.6

Development

Successfully merging this pull request may close these issues.

3 participants

@t413 @digitalentity @DzikuVx