Force the motors to stop until the throttle is raised in Autolaunch mode#6313
Closed
dragnea wants to merge 2 commits intoiNavFlight:masterfrom
Closed
Force the motors to stop until the throttle is raised in Autolaunch mode#6313dragnea wants to merge 2 commits intoiNavFlight:masterfrom
dragnea wants to merge 2 commits intoiNavFlight:masterfrom
Conversation
Member
|
Didn't notice this PR. Looks like we took the similar approach - see #6319 |
Contributor
Author
@digitalentity yep, please take a look over this discussion #6312 to see my point of view and the justification of the current commit b672f53, besides these 2 commits are 2 variants of fixing with different behaviour. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
nav_overrides_motor_stop = ALL_NAVthe motors will spin atthrottle_idleas soon as the arm is hit, so replacinggetThrottleIdleValue()withmotorConfig()->mincommandthe motors will be forced to stay off until the throttle is raised.The issue appeared in #6312