WP Mission Landing Elevation Setting #6822
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WP mission Landing currently assumes the landing elevation is the same as takeoff elevation which may not be the case for remote landings. If the remote landing elevation is different then landing vertical velocity scaling will be incorrect. This is more of an issue if the landing elevation is higher than takeoff elevation because the ground will appear sooner than INAV is expecting.
This PR provides the ability to define a different landing elevation to the default takeoff home elevation by setting Landing WP P1 as the landing elevation. Uses an elevation in cm which requires P1 to be changed to int32_t. Could maintain the current int16_t if the elevation was set in meters instead. This would be accurate enough for landing elevation but inconsistent with the altitude setting in cm leading to potential confusion with the settings.