Skip to content

Conversation

@mmosca
Copy link
Collaborator

@mmosca mmosca commented Sep 22, 2023

@sensei-hacker

This pull request updates most (all) targets to use the new TIM_USE_SERVO / TIM_USE_MOTOR for servos and motor, unlocking the benefits of the new timer allocation. Some targets may change the default output allocation and could need manual overrides to match an existing setup, but most seem to behave the same as before, with the default mixes.

AIO are left as TIM_USE_MOTOR, but I may have missed some.

Some targets did not assign motors to the first outputs in fixed wing mode, in those cases I have manually set an override on the expected timer.

Usually this would result in FW working as before, and MC working as before, as long as the number of motors is bigger than the outputs sharing a timer (usually 2).

Users can still change overrides after the fact and get whatever combination they want.

Quite a few targets had different outputs on the same timer with conflicting functions, these should all be fixed now.

@mmosca
Copy link
Collaborator Author

mmosca commented Sep 23, 2023

Other targets I have flagged during initial bulk changes

mosca@ham:~/dev/inav/src/main/target$ grep -r 'used to be fw moto' . | cut -d: -f1 | sort | uniq
./CLRACINGF4AIR/target.c
./FIREWORKSV2/target.c
./FOXEERH743/target.c
./GEPRCF722_BT_HD/target.c
./IFLIGHTF7_TWING/target.c
./MAMBAF405_2022A/target.c
./MAMBAH743/target.c
./MATEKF405CAN/target.c
./MATEKF722SE/target.c
./OMNIBUSF7NXT/target.c
./RUSH_BLADE_F7/target.c
./SKYSTARSF722HD/target.c
./SPEEDYBEEF4/target.c
./SPEEDYBEEF7MINI/target.c
./SPEEDYBEEF7V2/target.c
./SPRACINGF4EVO/target.c

I will need help reviewing/testing these :)
@mmosca
Copy link
Collaborator Author

mmosca commented Sep 23, 2023

RUSH_BLADE_F7 it favoring the mc configuration instead of fw, since it would end up with m1, m2, s1, s2, m3, m4 instelad of m1-m6

@mmosca mmosca marked this pull request as ready for review September 24, 2023 23:16
@mmosca mmosca added this to the 7.0 milestone Sep 25, 2023
@mmosca mmosca merged commit 39e8e7c into master Sep 25, 2023
@mmosca mmosca deleted the mmosca-pwm-target-updates branch September 25, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants