-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Bulk update targets with new pwm output assignments #9309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should improve INAV 6.x and older compatibility for fixed wing builds.
Collaborator
Author
|
Other targets I have flagged during initial bulk changes |
I will need help reviewing/testing these :)
Collaborator
Author
|
RUSH_BLADE_F7 it favoring the mc configuration instead of fw, since it would end up with m1, m2, s1, s2, m3, m4 instelad of m1-m6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sensei-hacker
This pull request updates most (all) targets to use the new TIM_USE_SERVO / TIM_USE_MOTOR for servos and motor, unlocking the benefits of the new timer allocation. Some targets may change the default output allocation and could need manual overrides to match an existing setup, but most seem to behave the same as before, with the default mixes.
AIO are left as TIM_USE_MOTOR, but I may have missed some.
Some targets did not assign motors to the first outputs in fixed wing mode, in those cases I have manually set an override on the expected timer.
Usually this would result in FW working as before, and MC working as before, as long as the number of motors is bigger than the outputs sharing a timer (usually 2).
Users can still change overrides after the fact and get whatever combination they want.
Quite a few targets had different outputs on the same timer with conflicting functions, these should all be fixed now.