Changes Provider and Direct Comparison functionality#245
Merged
diegopinate merged 46 commits intomasterfrom Jul 21, 2025
Merged
Changes Provider and Direct Comparison functionality#245diegopinate merged 46 commits intomasterfrom
diegopinate merged 46 commits intomasterfrom
Conversation
…l version of processing to use. Update view creation to use default view with all models.
…kend and input based on ChangedECInstance
…ation for UI purposes. Maintain visibility of driven elements when looking at models that contain changes for those driven elements.
… caused driven changes. Make relationships definable by frontend application instead of hard-coding it in the backend.
CalebGerman
reviewed
Jul 16, 2025
CalebGerman
reviewed
Jul 16, 2025
CalebGerman
reviewed
Jul 16, 2025
CalebGerman
reviewed
Jul 16, 2025
packages/changed-elements-react/src/widgets/EnhancedElementsInspector.tsx
Outdated
Show resolved
Hide resolved
CalebGerman
reviewed
Jul 16, 2025
packages/changed-elements-react/src/widgets/EnhancedElementsInspector.tsx
Show resolved
Hide resolved
CalebGerman
reviewed
Jul 16, 2025
packages/changed-elements-react/src/widgets/EnhancedElementsInspector.tsx
Outdated
Show resolved
Hide resolved
CalebGerman
reviewed
Jul 16, 2025
CalebGerman
reviewed
Jul 16, 2025
CalebGerman
reviewed
Jul 16, 2025
There was a problem hiding this comment.
Pull Request Overview
Adds a “direct comparison” workflow to both the test app and the changed-elements-react library by wiring in a new changes‐provider RPC path, custom styling overrides, and a selection callback.
- Introduce
useDirectComparisonflag and registerChangesRpcInterface/ChangesRpcImplon frontend and backend - Extend
VersionCompareoptions to acceptchangesProvider,colorOverrideProvider, andonInstancesSelected - Update widgets and visualization handlers to highlight driven elements and invoke custom callbacks
Reviewed Changes
Copilot reviewed 33 out of 34 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/test-app-frontend/src/environment.ts | Add useDirectComparison flag from environment variables |
| packages/test-app-frontend/src/App/ITwinJsApp/ITwinJsApp.tsx | Register ChangesRpcInterface, pass custom providers into VersionCompare.initialize |
| packages/test-app-backend/src/RPC/ChangesRpcInterface.ts | Define new RPC interface for fetching changed instances |
| packages/test-app-backend/src/RPC/ChangesRpcImpl.ts | Implement the RPC using ChangedInstancesProcessor |
| packages/changed-elements-react/src/api/VersionCompare.ts | Expand VersionCompareOptions to include changesProvider, colorOverrideProvider, and onInstancesSelected |
| packages/changed-elements-react/src/widgets/EnhancedElementsInspector.tsx | Invoke onInstancesSelected and inject driven-element highlighting |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
packages/changed-elements-react/src/widgets/EnhancedElementsInspector.tsx
Outdated
Show resolved
Hide resolved
packages/changed-elements-react/src/widgets/EnhancedElementsInspector.tsx
Outdated
Show resolved
Hide resolved
Collaborator
|
Looks like the lock file is not correct |
Collaborator
Author
Yes, I resolved that as well, had to update the pnpm version in the pipeline and fix some of the linting. See: |
CalebGerman
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to enhance changed elements react for:
Frontend Enhancements:
Backend Enhancements:
Test App Changes:
The Rpc is being implemented temporarily as part of the test-app-backend, but we will aim to move it to a separate package (potentially imodel-sync) to be consumable by other applications.