Add persistent-postgresql-ng package by iand675 · Pull Request #2 · iand675/persistent

iand675 · 2026-02-19T21:27:32Z

Summary

A PostgreSQL backend for persistent using the binary wire protocol and libpq pipeline mode.

Binary protocol via postgresql-binary (no text serialization)
Hedis-style automatic pipelining via lazy reply stream (unsafeInterleaveIO + atomicModifyIORef with head/tail)
UNNEST-based bulk inserts (fixed SQL template, single round-trip)
IN-clause collapse to = ANY($1)
Direct decode/encode path (zero PersistValue allocation)
PgDecode/PgEncode value-level codecs for compound types (arrays, composites)
FetchAll, FetchSingleRow, FetchChunked (PG17+) result fetch modes
DirectQueryCap wired into SqlBackend for the SqlBackend bridge
Pipelined get, insert, upsert, getBy, count, exists
24-29x speedup on individual reads at 1ms network latency

Benchmarks (1ms latency per direction)

Operation	persistent-postgresql	persistent-postgresql-ng	Speedup
get x100	310ms	11ms	28x
insert x100	314ms	13ms	24x
upsert x100	321ms	13ms	25x
delete x100	592ms	25ms	24x

A PostgreSQL backend for persistent using the binary wire protocol and libpq pipeline mode. Features: - Binary protocol via postgresql-binary (no text serialization) - Hedis-style automatic pipelining via lazy reply stream (unsafeInterleaveIO + atomicModifyIORef with head/tail) - UNNEST-based bulk inserts (fixed SQL template) - IN-clause collapse to = ANY($1) - Direct decode/encode path (zero PersistValue allocation) - PgDecode/PgEncode value-level codecs for compound types - FetchAll, FetchSingleRow, FetchChunked (PG17+) modes - DirectQueryCap wired into SqlBackend for SqlBackend bridge - Pipelined get, insert, upsert, getBy, count, exists - 24-29x speedup on reads at 1ms network latency Full test suite (363 tests across 3 fetch modes). Benchmarks with TCP delay proxy for latency simulation.

github-actions · 2026-02-19T21:27:52Z

+license-file:       LICENSE
+author:             Ian Duncan
+maintainer:         ian@ianduncan.me
+synopsis:           Pipelined PostgreSQL backend for persistent using binary protocol.


Restyled by cabal-fmt

Suggested change

synopsis: Pipelined PostgreSQL backend for persistent using binary protocol.

synopsis:

Pipelined PostgreSQL backend for persistent using binary protocol.

github-actions · 2026-02-19T21:27:52Z

+    Database.Persist.Postgresql.Internal.PgType
+    Database.Persist.Postgresql.Internal.Placeholders
+    Database.Persist.Postgresql.JSON
+    Database.Persist.Postgresql.CustomType


Restyled by cabal-fmt

Suggested change

Database.Persist.Postgresql.CustomType

Database.Persist.Postgresql.Pipeline

Database.Persist.Postgresql.Pipeline.FFI

Database.Persist.Postgresql.Pipeline.Internal

github-actions · 2026-02-19T21:27:52Z

+    BinaryRoundTripSpec
+    DirectDecodeSpec
+    DirectEntityPOC
+    CustomConstraintTest


Restyled by cabal-fmt

Suggested change

CustomConstraintTest

github-actions · 2026-02-19T21:27:52Z

+    | FetchChunked !Int
+      -- ^ Chunked mode (@PQsetChunkedRowsMode@, PG17+ libpq).  Each


Restyled by fourmolu

Suggested change

| FetchChunked !Int

-- ^ Chunked mode (@PQsetChunkedRowsMode@, PG17+ libpq). Each

FetchSingleRow

| -- | Chunked mode (@PQsetChunkedRowsMode@, PG17+ libpq). Each

github-actions · 2026-02-19T21:27:52Z

+scalarCUInt PgBool        = 16
+scalarCUInt PgBytea       = 17
+scalarCUInt PgChar        = 18
+scalarCUInt PgName        = 19
+scalarCUInt PgInt2        = 21
+scalarCUInt PgInt4        = 23
+scalarCUInt PgInt8        = 20
+scalarCUInt PgFloat4      = 700
+scalarCUInt PgFloat8      = 701
+scalarCUInt PgText        = 25
+scalarCUInt PgXml         = 142
+scalarCUInt PgMoney       = 790
+scalarCUInt PgBpchar      = 1042
+scalarCUInt PgVarchar     = 1043
+scalarCUInt PgDate        = 1082
+scalarCUInt PgTime        = 1083
+scalarCUInt PgTimestamp   = 1114


Restyled by fourmolu

Suggested change

scalarCUInt PgBool = 16

scalarCUInt PgBytea = 17

scalarCUInt PgChar = 18

scalarCUInt PgName = 19

scalarCUInt PgInt2 = 21

scalarCUInt PgInt4 = 23

scalarCUInt PgInt8 = 20

scalarCUInt PgFloat4 = 700

scalarCUInt PgFloat8 = 701

scalarCUInt PgText = 25

scalarCUInt PgXml = 142

scalarCUInt PgMoney = 790

scalarCUInt PgBpchar = 1042

scalarCUInt PgVarchar = 1043

scalarCUInt PgDate = 1082

scalarCUInt PgTime = 1083

scalarCUInt PgTimestamp = 1114

scalarCUInt PgBool = 16

scalarCUInt PgBytea = 17

scalarCUInt PgChar = 18

scalarCUInt PgName = 19

scalarCUInt PgInt2 = 21

scalarCUInt PgInt4 = 23

scalarCUInt PgInt8 = 20

scalarCUInt PgFloat4 = 700

scalarCUInt PgFloat8 = 701

scalarCUInt PgText = 25

scalarCUInt PgXml = 142

scalarCUInt PgMoney = 790

scalarCUInt PgBpchar = 1042

scalarCUInt PgVarchar = 1043

scalarCUInt PgDate = 1082

scalarCUInt PgTime = 1083

scalarCUInt PgTimestamp = 1114

github-actions · 2026-02-19T21:27:52Z

+    = QuestionMarkParams
+    -- ^ Traditional @?@ placeholders (persistent style). Each @?@ is a
+    -- distinct positional parameter.
+    | NumberedParams !Int
+    -- ^ PostgreSQL-native @$N@ placeholders.  The 'Int' is the highest
+    -- @$N@ found. A single @$1@ can appear multiple times in the query,
+    -- referencing the same parameter value.


Restyled by fourmolu

Suggested change

= QuestionMarkParams

-- ^ Traditional @?@ placeholders (persistent style). Each @?@ is a

-- distinct positional parameter.

| NumberedParams !Int

-- ^ PostgreSQL-native @$N@ placeholders. The 'Int' is the highest

-- @$N@ found. A single @$1@ can appear multiple times in the query,

-- referencing the same parameter value.

= -- | Traditional @?@ placeholders (persistent style). Each @?@ is a

-- distinct positional parameter.

QuestionMarkParams

| -- | PostgreSQL-native @$N@ placeholders. The 'Int' is the highest

-- @$N@ found. A single @$1@ can appear multiple times in the query,

-- referencing the same parameter value.

NumberedParams !Int

github-actions · 2026-02-19T21:27:52Z

+        (T.pack $ "Person " <> show i)
+        (20 + i `mod` 60)
+        (T.pack $ "person" <> show i <> "@test.com")
+    | i <- [1..n]


Restyled by fourmolu

Suggested change

| i <- [1..n]

| i <- [1 .. n]

github-actions · 2026-02-19T21:27:52Z

+    | FetchSingleRow
+      -- ^ Single-row mode (@PQsetSingleRowMode@).  Each @PGresult@ contains


Restyled by fourmolu

Suggested change

| FetchSingleRow

-- ^ Single-row mode (@PQsetSingleRowMode@). Each @PGresult@ contains

FetchAll

| -- | Single-row mode (@PQsetSingleRowMode@). Each @PGresult@ contains

github-actions · 2026-02-19T21:27:52Z

+        LibPQ.FlushOk      -> return ()
+        LibPQ.FlushFailed  -> throwIO $ PipelineExecError "flush failed"


Restyled by fourmolu

Suggested change

LibPQ.FlushOk -> return ()

LibPQ.FlushFailed -> throwIO $ PipelineExecError "flush failed"

LibPQ.FlushOk -> return ()

LibPQ.FlushFailed -> throwIO $ PipelineExecError "flush failed"

github-actions · 2026-02-19T21:27:52Z

+    Database.Persist.Postgresql.Pipeline.FFI
+    Database.Persist.Postgresql.Internal
+    Database.Persist.Postgresql.Internal.Decoding
+    Database.Persist.Postgresql.Internal.Encoding


Restyled by cabal-fmt

Suggested change

Database.Persist.Postgresql.Internal.Encoding

github-actions · 2026-02-19T21:27:52Z

+      aeson                >=1.0
+    , base                 >=4.9     && <5
+    , bytestring           >=0.10
+    , bytestring-strict-builder >=0.4
+    , conduit              >=1.2.12
+    , containers           >=0.5
+    , file-embed           >=0.0.16
+    , monad-logger         >=0.3.25


Restyled by cabal-fmt

Suggested change

aeson >=1.0

, base >=4.9 && <5

, bytestring >=0.10

, bytestring-strict-builder >=0.4

, conduit >=1.2.12

, containers >=0.5

, file-embed >=0.0.16

, monad-logger >=0.3.25

aeson >=1.0

, base >=4.9 && <5

, bytestring >=0.10

, bytestring-strict-builder >=0.4

, conduit >=1.2.12

, containers >=0.5

, file-embed >=0.0.16

, monad-logger >=0.3.25

github-actions · 2026-02-19T21:27:52Z

+    , bytestring
+    , containers
+    , fast-logger
+    , hspec                       >=2.4


Restyled by cabal-fmt

Suggested change

, hspec >=2.4

, hspec >=2.4

github-actions · 2026-02-19T21:27:52Z

+  ghc-options:      -Wall
+  build-depends:
+      aeson
+    , base                        >=4.9 && <5


Restyled by cabal-fmt

Suggested change

, base >=4.9 && <5

, base >=4.9 && <5

github-actions · 2026-02-19T21:27:52Z

+        _ -> do
+            merr <- LibPQ.errorMessage conn
+            LibPQ.finish conn
+            let msg = maybe "Unknown connection error" B8.unpack merr


Restyled by fourmolu

Suggested change

let msg = maybe "Unknown connection error" B8.unpack merr

let

msg = maybe "Unknown connection error" B8.unpack merr

github-actions · 2026-02-19T21:27:52Z

+  build-depends:
+      base                           >=4.9 && <5
+    , bytestring
+    , criterion                      >=1.5


Restyled by cabal-fmt

Suggested change

, criterion >=1.5

, criterion >=1.5

github-actions · 2026-02-19T21:27:52Z

+                mapM_ delete delKeys
+                forM_ updKeys $ \k -> update k [BenchPersonAge =. 99]
+                forM_ (zip repKeys (people 100)) $ \(k, person) ->
+                    replace k (person { benchPersonAge = 42 })


Restyled by fourmolu

Suggested change

replace k (person { benchPersonAge = 42 })

replace k (person{benchPersonAge = 42})

github-actions · 2026-02-19T21:27:52Z

+   -> ReaderT (PgPipeline.WriteBackend PgPipeline.PostgreSQLBackend) IO a -> IO a
+pl pool action = runSqlPool action pool
+
+


Restyled by fourmolu

Suggested change

github-actions · 2026-02-19T21:27:52Z

+import Data.Pool (Pool)
+import Data.Text (Text)
+import qualified Data.Text as T
+import Control.Monad.Trans.Reader (ReaderT, withReaderT)


Restyled by fourmolu

Suggested change

import Control.Monad.Trans.Reader (ReaderT, withReaderT)

github-actions · 2026-02-19T21:27:52Z

+scalarCUInt PgInterval    = 1186
+scalarCUInt PgBit         = 1560
+scalarCUInt PgVarbit      = 1562
+scalarCUInt PgNumeric     = 1700
+scalarCUInt PgVoid        = 2278
+scalarCUInt PgJson        = 114
+scalarCUInt PgJsonb       = 3802
+scalarCUInt PgUnknown     = 705
+scalarCUInt PgUuid        = 2950


Restyled by fourmolu

Suggested change

scalarCUInt PgInterval = 1186

scalarCUInt PgBit = 1560

scalarCUInt PgVarbit = 1562

scalarCUInt PgNumeric = 1700

scalarCUInt PgVoid = 2278

scalarCUInt PgJson = 114

scalarCUInt PgJsonb = 3802

scalarCUInt PgUnknown = 705

scalarCUInt PgUuid = 2950

scalarCUInt PgInterval = 1186

scalarCUInt PgBit = 1560

scalarCUInt PgVarbit = 1562

scalarCUInt PgNumeric = 1700

scalarCUInt PgVoid = 2278

scalarCUInt PgJson = 114

scalarCUInt PgJsonb = 3802

scalarCUInt PgUnknown = 705

scalarCUInt PgUuid = 2950

github-actions · 2026-02-19T21:27:52Z

+    drainToSyncClose conn = do
+        mret <- LibPQ.getResult conn
+        case mret of
+            Nothing -> drainToSyncClose conn  -- NULL separator, keep reading


Restyled by fourmolu

Suggested change

Nothing -> drainToSyncClose conn -- NULL separator, keep reading

Nothing -> drainToSyncClose conn -- NULL separator, keep reading

github-actions · 2026-02-19T21:27:52Z

+    | PgUnknown
+    -- ^ The PostgreSQL @unknown@ pseudotype (OID 705), used for untyped
+    -- string literals.  Not to be confused with 'Unrecognized'.


Restyled by fourmolu

Suggested change

| PgUnknown

-- ^ The PostgreSQL @unknown@ pseudotype (OID 705), used for untyped

-- string literals. Not to be confused with 'Unrecognized'.

| -- | The PostgreSQL @unknown@ pseudotype (OID 705), used for untyped

-- string literals. Not to be confused with 'Unrecognized'.

PgUnknown

github-actions · 2026-02-19T21:27:52Z

+        let (_, pt) = pgCols env V.! col
+        in case pt of
+            Scalar PgText    -> onOk (mkRunner col PD.text_strict)
+            Scalar PgVarchar -> onOk (mkRunner col PD.text_strict)
+            Scalar PgBpchar  -> onOk (mkRunner col PD.text_strict)
+            Scalar PgChar    -> onOk (mkRunner col PD.text_strict)
+            Scalar PgName    -> onOk (mkRunner col PD.text_strict)
+            _                -> mismatch pt "Text" onErr


Restyled by fourmolu

Suggested change

let (_, pt) = pgCols env V.! col

in case pt of

Scalar PgText -> onOk (mkRunner col PD.text_strict)

Scalar PgVarchar -> onOk (mkRunner col PD.text_strict)

Scalar PgBpchar -> onOk (mkRunner col PD.text_strict)

Scalar PgChar -> onOk (mkRunner col PD.text_strict)

Scalar PgName -> onOk (mkRunner col PD.text_strict)

_ -> mismatch pt "Text" onErr

let

(_, pt) = pgCols env V.! col

in

case pt of

Scalar PgText -> onOk (mkRunner col PD.text_strict)

Scalar PgVarchar -> onOk (mkRunner col PD.text_strict)

Scalar PgBpchar -> onOk (mkRunner col PD.text_strict)

Scalar PgChar -> onOk (mkRunner col PD.text_strict)

Scalar PgName -> onOk (mkRunner col PD.text_strict)

_ -> mismatch pt "Text" onErr

github-actions · 2026-02-19T21:27:52Z

+    | otherwise = BS.pack $ concat
+        [ hexBytes 0 4, [0x2D]
+        , hexBytes 4 2, [0x2D]
+        , hexBytes 6 2, [0x2D]
+        , hexBytes 8 2, [0x2D]
+        , hexBytes 10 6
+        ]


Restyled by fourmolu

Suggested change

| otherwise = BS.pack $ concat

[ hexBytes 0 4, [0x2D]

, hexBytes 4 2, [0x2D]

, hexBytes 6 2, [0x2D]

, hexBytes 8 2, [0x2D]

, hexBytes 10 6

]

| otherwise =

BS.pack $

concat

[ hexBytes 0 4

, [0x2D]

, hexBytes 4 2

, [0x2D]

, hexBytes 6 2

, [0x2D]

, hexBytes 8 2

, [0x2D]

, hexBytes 10 6

]

github-actions · 2026-02-19T21:27:52Z

+    :: PgDecode a
+    => PgRowEnv -> FieldNameDB -> Int
+    -> (Text -> IO r) -> (FieldRunner PgRowEnv a -> IO r) -> IO r


Restyled by fourmolu

Suggested change

:: PgDecode a

=> PgRowEnv -> FieldNameDB -> Int

-> (Text -> IO r) -> (FieldRunner PgRowEnv a -> IO r) -> IO r

:: (PgDecode a)

=> PgRowEnv

-> FieldNameDB

-> Int

-> (Text -> IO r)

-> (FieldRunner PgRowEnv a -> IO r)

-> IO r

github-actions · 2026-02-19T21:27:52Z

+decodeWith decoder bs onErr onOk =
+    case PD.valueParser decoder bs of
+        Left err -> onErr err
+        Right v  -> onOk v


Restyled by fourmolu

Suggested change

Right v -> onOk v

Right v -> onOk v

github-actions · 2026-02-19T21:27:52Z

+import Control.Monad (replicateM)
+import Data.Word (Word8)


Restyled by fourmolu

Suggested change

import Control.Monad (replicateM)

import Data.Word (Word8)

github-actions · 2026-02-19T21:27:52Z

+-- Generic array instance via PgDecode
+---------------------------------------------------------------------------
+
+instance {-# OVERLAPPABLE #-} PgDecode a => FieldDecode PgRowEnv [a] where


Restyled by fourmolu

Suggested change

instance {-# OVERLAPPABLE #-} PgDecode a => FieldDecode PgRowEnv [a] where

instance {-# OVERLAPPABLE #-} (PgDecode a) => FieldDecode PgRowEnv [a] where

github-actions · 2026-02-19T21:27:52Z

+pgTypeOid (Scalar s)          = scalarOid s
+pgTypeOid (Array s)           = maybe (LibPQ.Oid 0) id (arrayOid s)
+pgTypeOid (Composite _ _)     = LibPQ.Oid 0
+pgTypeOid (CompositeArray _)  = LibPQ.Oid 0
+pgTypeOid (Enum _ _)          = LibPQ.Oid 0
+pgTypeOid (EnumArray _)       = LibPQ.Oid 0
+pgTypeOid (Unrecognized n)    = LibPQ.Oid (fromIntegral n)


Restyled by fourmolu

Suggested change

pgTypeOid (Scalar s) = scalarOid s

pgTypeOid (Array s) = maybe (LibPQ.Oid 0) id (arrayOid s)

pgTypeOid (Composite _ _) = LibPQ.Oid 0

pgTypeOid (CompositeArray _) = LibPQ.Oid 0

pgTypeOid (Enum _ _) = LibPQ.Oid 0

pgTypeOid (EnumArray _) = LibPQ.Oid 0

pgTypeOid (Unrecognized n) = LibPQ.Oid (fromIntegral n)

pgTypeOid (Scalar s) = scalarOid s

pgTypeOid (Array s) = maybe (LibPQ.Oid 0) id (arrayOid s)

pgTypeOid (Composite _ _) = LibPQ.Oid 0

pgTypeOid (CompositeArray _) = LibPQ.Oid 0

pgTypeOid (Enum _ _) = LibPQ.Oid 0

pgTypeOid (EnumArray _) = LibPQ.Oid 0

pgTypeOid (Unrecognized n) = LibPQ.Oid (fromIntegral n)

github-actions · 2026-02-19T21:27:52Z

+        in case pt of
+            Array _        -> onOk (mkRunner col decoder)
+            Unrecognized _ -> onOk (mkRunner col decoder)
+            _              -> mismatch pt "array" onErr


Restyled by fourmolu

Suggested change

in case pt of

Array _ -> onOk (mkRunner col decoder)

Unrecognized _ -> onOk (mkRunner col decoder)

_ -> mismatch pt "array" onErr

in

case pt of

Array _ -> onOk (mkRunner col decoder)

Unrecognized _ -> onOk (mkRunner col decoder)

_ -> mismatch pt "array" onErr

github-actions · 2026-02-19T21:27:52Z

+        let (_, pt) = pgCols env V.! col
+        in case pt of
+            Scalar PgBytea   -> onOk (mkRunner col PD.bytea_strict)
+            Scalar PgXml     -> onOk (mkRunner col PD.bytea_strict)
+            Scalar PgJson    -> onOk (mkRunner col PD.bytea_strict)
+            Scalar PgJsonb   -> onOk (mkRunner col (PD.jsonb_bytes Right))
+            Scalar PgBit     -> onOk (mkRunner col PD.bytea_strict)
+            Scalar PgVarbit  -> onOk (mkRunner col PD.bytea_strict)
+            Scalar PgUnknown -> onOk (mkRunner col PD.bytea_strict)
+            _                -> mismatch pt "ByteString" onErr


Restyled by fourmolu

Suggested change

let (_, pt) = pgCols env V.! col

in case pt of

Scalar PgBytea -> onOk (mkRunner col PD.bytea_strict)

Scalar PgXml -> onOk (mkRunner col PD.bytea_strict)

Scalar PgJson -> onOk (mkRunner col PD.bytea_strict)

Scalar PgJsonb -> onOk (mkRunner col (PD.jsonb_bytes Right))

Scalar PgBit -> onOk (mkRunner col PD.bytea_strict)

Scalar PgVarbit -> onOk (mkRunner col PD.bytea_strict)

Scalar PgUnknown -> onOk (mkRunner col PD.bytea_strict)

_ -> mismatch pt "ByteString" onErr

let

(_, pt) = pgCols env V.! col

in

case pt of

Scalar PgBytea -> onOk (mkRunner col PD.bytea_strict)

Scalar PgXml -> onOk (mkRunner col PD.bytea_strict)

Scalar PgJson -> onOk (mkRunner col PD.bytea_strict)

Scalar PgJsonb -> onOk (mkRunner col (PD.jsonb_bytes Right))

Scalar PgBit -> onOk (mkRunner col PD.bytea_strict)

Scalar PgVarbit -> onOk (mkRunner col PD.bytea_strict)

Scalar PgUnknown -> onOk (mkRunner col PD.bytea_strict)

_ -> mismatch pt "ByteString" onErr

github-actions · 2026-02-19T21:27:52Z

+decodeByType (Scalar PgInterval)    bs = PersistRational . toRational <$> run PD.interval_int bs
+decodeByType (Scalar PgBit)         bs = PersistByteString <$> run PD.bytea_strict bs
+decodeByType (Scalar PgVarbit)      bs = PersistByteString <$> run PD.bytea_strict bs
+decodeByType (Scalar PgNumeric)     bs = decodeNumeric bs
+decodeByType (Scalar PgVoid)        _  = Right PersistNull
+decodeByType (Scalar PgJson)        bs = PersistByteString <$> run PD.bytea_strict bs
+decodeByType (Scalar PgJsonb)       bs = PersistByteString <$> decodeJsonb bs
+decodeByType (Scalar PgUnknown)     bs = PersistByteString <$> run PD.bytea_strict bs
+decodeByType (Scalar PgUuid)        bs = do


Restyled by fourmolu

Suggested change

decodeByType (Scalar PgInterval) bs = PersistRational . toRational <$> run PD.interval_int bs

decodeByType (Scalar PgBit) bs = PersistByteString <$> run PD.bytea_strict bs

decodeByType (Scalar PgVarbit) bs = PersistByteString <$> run PD.bytea_strict bs

decodeByType (Scalar PgNumeric) bs = decodeNumeric bs

decodeByType (Scalar PgVoid) _ = Right PersistNull

decodeByType (Scalar PgJson) bs = PersistByteString <$> run PD.bytea_strict bs

decodeByType (Scalar PgJsonb) bs = PersistByteString <$> decodeJsonb bs

decodeByType (Scalar PgUnknown) bs = PersistByteString <$> run PD.bytea_strict bs

decodeByType (Scalar PgUuid) bs = do

decodeByType (Scalar PgInterval) bs = PersistRational . toRational <$> run PD.interval_int bs

decodeByType (Scalar PgBit) bs = PersistByteString <$> run PD.bytea_strict bs

decodeByType (Scalar PgVarbit) bs = PersistByteString <$> run PD.bytea_strict bs

decodeByType (Scalar PgNumeric) bs = decodeNumeric bs

decodeByType (Scalar PgVoid) _ = Right PersistNull

decodeByType (Scalar PgJson) bs = PersistByteString <$> run PD.bytea_strict bs

decodeByType (Scalar PgJsonb) bs = PersistByteString <$> decodeJsonb bs

decodeByType (Scalar PgUnknown) bs = PersistByteString <$> run PD.bytea_strict bs

decodeByType (Scalar PgUuid) bs = do

github-actions · 2026-02-19T21:27:52Z

+import Data.Scientific (Scientific)
+import Data.Text (Text)
+import Data.Time (localTimeToUTC, utc)
+import qualified Database.PostgreSQL.LibPQ as LibPQ


Restyled by fourmolu

Suggested change

import qualified Database.PostgreSQL.LibPQ as LibPQ

import Data.Word (Word8)

github-actions · 2026-02-19T21:27:52Z

+            Unrecognized _ -> onOk (mkRunner col decoder)
+            _              -> mismatch pt "array" onErr
+
+instance {-# OVERLAPPING #-} PgDecode a => FieldDecode PgRowEnv [Maybe a] where


Restyled by fourmolu

Suggested change

instance {-# OVERLAPPING #-} PgDecode a => FieldDecode PgRowEnv [Maybe a] where

instance {-# OVERLAPPING #-} (PgDecode a) => FieldDecode PgRowEnv [Maybe a] where

github-actions · 2026-02-19T21:27:52Z

+import qualified Data.Text
+import qualified Data.Text.Encoding
+import Data.Time (NominalDiffTime)
+import Database.Persist.Sql


Restyled by fourmolu

Suggested change

import Database.Persist.Sql

github-actions · 2026-02-19T21:27:52Z

+        let (_, pt) = pgCols env V.! col
+        in case pt of
+            Scalar PgNumeric -> onOk (mkRunnerWith col PD.numeric (toRational :: Scientific -> Rational))
+            Scalar PgMoney   -> onOk (mkRunnerWith col (PD.int :: PD.Value Int64) fromIntegral)
+            _                -> mismatch pt "Rational" onErr


Restyled by fourmolu

Suggested change

let (_, pt) = pgCols env V.! col

in case pt of

Scalar PgNumeric -> onOk (mkRunnerWith col PD.numeric (toRational :: Scientific -> Rational))

Scalar PgMoney -> onOk (mkRunnerWith col (PD.int :: PD.Value Int64) fromIntegral)

_ -> mismatch pt "Rational" onErr

let

(_, pt) = pgCols env V.! col

in

case pt of

Scalar PgNumeric -> onOk (mkRunnerWith col PD.numeric (toRational :: Scientific -> Rational))

Scalar PgMoney -> onOk (mkRunnerWith col (PD.int :: PD.Value Int64) fromIntegral)

_ -> mismatch pt "Rational" onErr

github-actions · 2026-02-19T21:27:52Z

+        let (_, pt) = pgCols env V.! col
+        in case pt of
+            Scalar PgInt8 -> onOk (mkRunner col (PD.int :: PD.Value Int64))
+            Scalar PgInt4 -> onOk (mkRunnerWith col (PD.int :: PD.Value Int32) fromIntegral)
+            Scalar PgInt2 -> onOk (mkRunnerWith col (PD.int :: PD.Value Int16) fromIntegral)
+            _             -> mismatch pt "Int64" onErr


Restyled by fourmolu

Suggested change

let (_, pt) = pgCols env V.! col

in case pt of

Scalar PgInt8 -> onOk (mkRunner col (PD.int :: PD.Value Int64))

Scalar PgInt4 -> onOk (mkRunnerWith col (PD.int :: PD.Value Int32) fromIntegral)

Scalar PgInt2 -> onOk (mkRunnerWith col (PD.int :: PD.Value Int16) fromIntegral)

_ -> mismatch pt "Int64" onErr

let

(_, pt) = pgCols env V.! col

in

case pt of

Scalar PgInt8 -> onOk (mkRunner col (PD.int :: PD.Value Int64))

Scalar PgInt4 -> onOk (mkRunnerWith col (PD.int :: PD.Value Int32) fromIntegral)

Scalar PgInt2 -> onOk (mkRunnerWith col (PD.int :: PD.Value Int16) fromIntegral)

_ -> mismatch pt "Int64" onErr

github-actions · 2026-02-19T21:27:52Z

+resolveOid :: OidCache -> LibPQ.Oid -> PgType
+resolveOid cache oid = case fromOid oid of
+    Unrecognized n -> maybe (Unrecognized n) id (IntMap.lookup n cache)
+    known          -> known


Restyled by fourmolu

Suggested change

known -> known

known -> known

github-actions · 2026-02-19T21:27:52Z

+arrayCUInt PgInterval    = Just 1187
+arrayCUInt PgBit         = Just 1561
+arrayCUInt PgVarbit      = Just 1563
+arrayCUInt PgNumeric     = Just 1231
+arrayCUInt PgJson        = Just 199
+arrayCUInt PgJsonb       = Just 3807
+arrayCUInt PgUuid        = Just 2951
+arrayCUInt PgVoid        = Nothing
+arrayCUInt PgUnknown     = Nothing


Restyled by fourmolu

Suggested change

arrayCUInt PgInterval = Just 1187

arrayCUInt PgBit = Just 1561

arrayCUInt PgVarbit = Just 1563

arrayCUInt PgNumeric = Just 1231

arrayCUInt PgJson = Just 199

arrayCUInt PgJsonb = Just 3807

arrayCUInt PgUuid = Just 2951

arrayCUInt PgVoid = Nothing

arrayCUInt PgUnknown = Nothing

arrayCUInt PgInterval = Just 1187

arrayCUInt PgBit = Just 1561

arrayCUInt PgVarbit = Just 1563

arrayCUInt PgNumeric = Just 1231

arrayCUInt PgJson = Just 199

arrayCUInt PgJsonb = Just 3807

arrayCUInt PgUuid = Just 2951

arrayCUInt PgVoid = Nothing

arrayCUInt PgUnknown = Nothing

github-actions · 2026-02-19T21:27:52Z

+decodeByType (Scalar PgBool)        bs = PersistBool <$> run PD.bool bs
+decodeByType (Scalar PgBytea)       bs = PersistByteString <$> run PD.bytea_strict bs
+decodeByType (Scalar PgChar)        bs = PersistText <$> run PD.text_strict bs
+decodeByType (Scalar PgName)        bs = PersistText <$> run PD.text_strict bs
+decodeByType (Scalar PgInt8)        bs = PersistInt64 <$> run (PD.int :: PD.Value Int64) bs
+decodeByType (Scalar PgInt2)        bs = PersistInt64 . fromIntegral <$> run (PD.int :: PD.Value Int16) bs
+decodeByType (Scalar PgInt4)        bs = PersistInt64 . fromIntegral <$> run (PD.int :: PD.Value Int32) bs
+decodeByType (Scalar PgText)        bs = PersistText <$> run PD.text_strict bs
+decodeByType (Scalar PgXml)         bs = PersistByteString <$> run PD.bytea_strict bs
+decodeByType (Scalar PgFloat4)      bs = PersistDouble . realToFrac <$> run PD.float4 bs
+decodeByType (Scalar PgFloat8)      bs = PersistDouble <$> run PD.float8 bs
+decodeByType (Scalar PgMoney)       bs = PersistRational . fromIntegral <$> run (PD.int :: PD.Value Int64) bs
+decodeByType (Scalar PgBpchar)      bs = PersistText <$> run PD.text_strict bs
+decodeByType (Scalar PgVarchar)     bs = PersistText <$> run PD.text_strict bs
+decodeByType (Scalar PgDate)        bs = PersistDay <$> run PD.date bs
+decodeByType (Scalar PgTime)        bs = PersistTimeOfDay <$> run PD.time_int bs
+decodeByType (Scalar PgTimestamp)   bs = PersistUTCTime . localTimeToUTC utc <$> run PD.timestamp_int bs


Restyled by fourmolu

Suggested change

decodeByType (Scalar PgBool) bs = PersistBool <$> run PD.bool bs

decodeByType (Scalar PgBytea) bs = PersistByteString <$> run PD.bytea_strict bs

decodeByType (Scalar PgChar) bs = PersistText <$> run PD.text_strict bs

decodeByType (Scalar PgName) bs = PersistText <$> run PD.text_strict bs

decodeByType (Scalar PgInt8) bs = PersistInt64 <$> run (PD.int :: PD.Value Int64) bs

decodeByType (Scalar PgInt2) bs = PersistInt64 . fromIntegral <$> run (PD.int :: PD.Value Int16) bs

decodeByType (Scalar PgInt4) bs = PersistInt64 . fromIntegral <$> run (PD.int :: PD.Value Int32) bs

decodeByType (Scalar PgText) bs = PersistText <$> run PD.text_strict bs

decodeByType (Scalar PgXml) bs = PersistByteString <$> run PD.bytea_strict bs

decodeByType (Scalar PgFloat4) bs = PersistDouble . realToFrac <$> run PD.float4 bs

decodeByType (Scalar PgFloat8) bs = PersistDouble <$> run PD.float8 bs

decodeByType (Scalar PgMoney) bs = PersistRational . fromIntegral <$> run (PD.int :: PD.Value Int64) bs

decodeByType (Scalar PgBpchar) bs = PersistText <$> run PD.text_strict bs

decodeByType (Scalar PgVarchar) bs = PersistText <$> run PD.text_strict bs

decodeByType (Scalar PgDate) bs = PersistDay <$> run PD.date bs

decodeByType (Scalar PgTime) bs = PersistTimeOfDay <$> run PD.time_int bs

decodeByType (Scalar PgTimestamp) bs = PersistUTCTime . localTimeToUTC utc <$> run PD.timestamp_int bs

decodeByType (Scalar PgBool) bs = PersistBool <$> run PD.bool bs

decodeByType (Scalar PgBytea) bs = PersistByteString <$> run PD.bytea_strict bs

decodeByType (Scalar PgChar) bs = PersistText <$> run PD.text_strict bs

decodeByType (Scalar PgName) bs = PersistText <$> run PD.text_strict bs

decodeByType (Scalar PgInt8) bs = PersistInt64 <$> run (PD.int :: PD.Value Int64) bs

decodeByType (Scalar PgInt2) bs = PersistInt64 . fromIntegral <$> run (PD.int :: PD.Value Int16) bs

decodeByType (Scalar PgInt4) bs = PersistInt64 . fromIntegral <$> run (PD.int :: PD.Value Int32) bs

decodeByType (Scalar PgText) bs = PersistText <$> run PD.text_strict bs

decodeByType (Scalar PgXml) bs = PersistByteString <$> run PD.bytea_strict bs

decodeByType (Scalar PgFloat4) bs = PersistDouble . realToFrac <$> run PD.float4 bs

decodeByType (Scalar PgFloat8) bs = PersistDouble <$> run PD.float8 bs

decodeByType (Scalar PgMoney) bs = PersistRational . fromIntegral <$> run (PD.int :: PD.Value Int64) bs

decodeByType (Scalar PgBpchar) bs = PersistText <$> run PD.text_strict bs

decodeByType (Scalar PgVarchar) bs = PersistText <$> run PD.text_strict bs

decodeByType (Scalar PgDate) bs = PersistDay <$> run PD.date bs

decodeByType (Scalar PgTime) bs = PersistTimeOfDay <$> run PD.time_int bs

decodeByType (Scalar PgTimestamp) bs = PersistUTCTime . localTimeToUTC utc <$> run PD.timestamp_int bs

github-actions · 2026-02-19T21:27:52Z

+fromCUInt 16   = Scalar PgBool
+fromCUInt 17   = Scalar PgBytea
+fromCUInt 18   = Scalar PgChar
+fromCUInt 19   = Scalar PgName
+fromCUInt 20   = Scalar PgInt8
+fromCUInt 21   = Scalar PgInt2
+fromCUInt 23   = Scalar PgInt4
+fromCUInt 25   = Scalar PgText
+fromCUInt 114  = Scalar PgJson
+fromCUInt 142  = Scalar PgXml
+fromCUInt 700  = Scalar PgFloat4
+fromCUInt 701  = Scalar PgFloat8
+fromCUInt 705  = Scalar PgUnknown
+fromCUInt 790  = Scalar PgMoney


Restyled by fourmolu

Suggested change

fromCUInt 16 = Scalar PgBool

fromCUInt 17 = Scalar PgBytea

fromCUInt 18 = Scalar PgChar

fromCUInt 19 = Scalar PgName

fromCUInt 20 = Scalar PgInt8

fromCUInt 21 = Scalar PgInt2

fromCUInt 23 = Scalar PgInt4

fromCUInt 25 = Scalar PgText

fromCUInt 114 = Scalar PgJson

fromCUInt 142 = Scalar PgXml

fromCUInt 700 = Scalar PgFloat4

fromCUInt 701 = Scalar PgFloat8

fromCUInt 705 = Scalar PgUnknown

fromCUInt 790 = Scalar PgMoney

fromCUInt 16 = Scalar PgBool

fromCUInt 17 = Scalar PgBytea

fromCUInt 18 = Scalar PgChar

fromCUInt 19 = Scalar PgName

fromCUInt 20 = Scalar PgInt8

fromCUInt 21 = Scalar PgInt2

fromCUInt 23 = Scalar PgInt4

fromCUInt 25 = Scalar PgText

fromCUInt 114 = Scalar PgJson

fromCUInt 142 = Scalar PgXml

fromCUInt 700 = Scalar PgFloat4

fromCUInt 701 = Scalar PgFloat8

fromCUInt 705 = Scalar PgUnknown

fromCUInt 790 = Scalar PgMoney

github-actions Bot reviewed Feb 19, 2026

View reviewed changes

iand675 mentioned this pull request Feb 19, 2026

RFC: Direct row codecs for persistent yesodweb/persistent#1618

Open

1 task

		\| FetchChunked !Int
		-- ^ Chunked mode (@PQsetChunkedRowsMode@, PG17+ libpq). Each

		\| FetchSingleRow
		-- ^ Single-row mode (@PQsetSingleRowMode@). Each @PGresult@ contains

		LibPQ.FlushOk -> return ()
		LibPQ.FlushFailed -> throwIO $ PipelineExecError "flush failed"

	let msg = maybe "Unknown connection error" B8.unpack merr
	let
	msg = maybe "Unknown connection error" B8.unpack merr

	replace k (person { benchPersonAge = 42 })
	replace k (person{benchPersonAge = 42})

		-> ReaderT (PgPipeline.WriteBackend PgPipeline.PostgreSQLBackend) IO a -> IO a
		pl pool action = runSqlPool action pool

	Nothing -> drainToSyncClose conn -- NULL separator, keep reading
	Nothing -> drainToSyncClose conn -- NULL separator, keep reading

	instance {-# OVERLAPPABLE #-} PgDecode a => FieldDecode PgRowEnv [a] where
	instance {-# OVERLAPPABLE #-} (PgDecode a) => FieldDecode PgRowEnv [a] where

	import qualified Database.PostgreSQL.LibPQ as LibPQ
	import Data.Word (Word8)

	instance {-# OVERLAPPING #-} PgDecode a => FieldDecode PgRowEnv [Maybe a] where
	instance {-# OVERLAPPING #-} (PgDecode a) => FieldDecode PgRowEnv [Maybe a] where

Conversation

iand675 commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Benchmarks (1ms latency per direction)

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

iand675 commented Feb 19, 2026 •

edited

Loading