Remove Deliverfile related functionality#3
Closed
iangmaia wants to merge 4 commits intocleanup/remove-legacy-localization-toolingfrom
Closed
Remove Deliverfile related functionality#3iangmaia wants to merge 4 commits intocleanup/remove-legacy-localization-toolingfrom
iangmaia wants to merge 4 commits intocleanup/remove-legacy-localization-toolingfrom
Conversation
4 tasks
Merged
4 tasks
AliSoftware
reviewed
Jan 31, 2023
There was a problem hiding this comment.
Left a small note about the title of a spec, otherwise looks good!
Note: reminder to reviewers that we might want to wait for us to ensure all the client apps have been updated to stop relying on the
Deliverfileto provide theapp_versionanymore first, before we can land this change.
Better have the client apps ready before we ship the major version of the toolkit, rather than those client apps being blocked from updating the release-toolkit (e.g. if we need a new thing that will land in the release-toolkit after that change, but the client were still relying on the app_version being defined in Deliverfile, but we might not have time/priority to fix that aspect in the client then…)
1cad793 to
976d67d
Compare
976d67d to
acae9e7
Compare
1 task
AliSoftware
reviewed
Feb 10, 2023
Co-authored-by: Olivier Halligon <olivier@halligon.net>
This was referenced Feb 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDIT: This PR was re-created in the main repo as wordpress-mobile#450
What does it do?
On this discussion I had with @AliSoftware he mentioned that using the
Deliverfileto configure the app version became obsolete, so this PR removes all references to it.It implements:
include_deliverfileparameter inIos::GitHelper.commit_version_bump()and all call sites.skip_deliverConfigItem in the actionsios_bump_version_hotfixandios_bump_version_release.rb.Ios::VersionHelper::update_fastlane_deliver().Related PRs
skip_glotpressand related cleanup wordpress-mobile/release-toolkit#443 .Next steps
The idea is that the current
Ios::GitHelper.commit_version_bump()will become obsolete, given now all it does is committing the hard-coded/config/folder. So based on this work, we can also removeIos::GitHelper.commit_version_bump()and commit the.xcconfigdirectly from where it's being changed.Checklist before requesting a review
bundle exec rubocopto test for code style violations and recommendationsspecs/*_spec.rb) if applicablebundle exec rspecto run the whole test suite and ensure all your tests passCHANGELOG.mdfile to describe your changes under the approprioate existing###subsection of the existing## Trunksection.