Skip to content

Conversation

@lmars
Copy link
Contributor

@lmars lmars commented May 9, 2012

This is necessary as Module.instance_methods contains Strings in < 1.9, and Symbols in >= 1.9

@ianwhite
Copy link
Owner

Hi Lewis,

Thanks for this, it's in master now. I have noticed some failing tests (not to do with this change). When they are fixed I'll release 2.1.1.

Cheers,
Ian

On 9 May 2012, at 14:40, Lewis Marshall wrote:

This is necessary as Module.instance_methods contains Strings in < 1.9, and Symbols in >= 1.9

You can merge this Pull Request by running:

git pull https://github.com/econsultancy/resources_controller econsultancy-ruby-1.9.3

Or you can view, comment on it, or merge it online at:

#9

-- Commit Summary --

  • Handle instance_methods containing Symbols in Ruby >= 1.9

-- File Changes --

M lib/resources_controller/include_actions.rb (5)

-- Patch Links --

https://github.com/ianwhite/resources_controller/pull/9.patch
https://github.com/ianwhite/resources_controller/pull/9.diff


Reply to this email directly or view it on GitHub:
#9

@lmars
Copy link
Contributor Author

lmars commented May 11, 2012

Thanks Ian

@lmars lmars closed this May 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants