[patch] Fix check for AIService upgrade compatibility #2019
Conversation
| # does not supply a target upgrade version. | ||
| aiservice_upgrade_path: | ||
| 9.1.x: 9.2.x-feature | ||
| 9.1.x: [9.2.x-feature] |
There was a problem hiding this comment.
I thought there was always a one to one mapping for the upgrade path i.e. you can't have more than one "to" channel to upgrade too. For the 9.2.x-feature, that is the only channel until 9.2.x comes out, at which point 9.2.x-feature would not be a valid option.
There was a problem hiding this comment.
Table is updated to remove the list and allow only one upgrade target version.
| @@ -0,0 +1,70 @@ | |||
| # ----------------------------------------------------------- | |||
There was a problem hiding this comment.
Errrrrrm, I hope this is just a mistake of putting the wrong license file in place, rather than copying product code into this repo?
ansible-devops is open source code, licensed under the EPL, we can not published licensed materials in this repository
There was a problem hiding this comment.
This same header is already present in the repo here: https://github.com/ibm-mas/ansible-devops/blob/master/ibm/mas_devops/plugins/filter/filters.py#L2
durera
changed the title
Issue
MASAIB-1626
Description
aiservice_channel in aiservice_upgrade_path, however,aiservice_upgrade_pathis a dictionary so this check is insufficient; we need to check if (a) the currently installed AI Service channel is a valid key in the dictionary, and (b) if the values for this key include the channel version we want to upgrade to. The PR adds a new filter function to perform this check.Test Results
AI Service upgrade has been successfully tested with these changes included in custom branch #2021