Suggestion/git submodules4annotation sources#127
Open
wtoorop wants to merge 2 commits intoicann:mainfrom
Open
Conversation
Because www.rfc-editor.org returns 403: Forbidden otherwise
This is just a suggestion. Instead of pulling the annotation sources from python they could also be added to the repository as git submodules. You need less of your own code (so less that can go wrong there), and allows working within the git ecosystem in the with git convential ways (such as adding more submodules in your own fork etc.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a suggestion. Instead of pulling the annotation sources from python they could also be added to the repository as git submodules. You need less of your own code (so less that can go wrong there), and allows working within the git ecosystem in the with git conventional ways (such as adding more submodules in your own fork etc.)
Beware
git submodule update --initYou can also just close this PR, because the old way is also works just fine. I just wanted to mention this possibility and it seemed easy enough to just do it so you can have a look and evaluate.