Find occurrences whose duration intersects a time window

[avit]

We have occurrences_between, but this only covers start times in the range, not all occurrences whose duration intersects the window (those that already started before, and are presently counted by occurring_between?).

I vote for adding open_occurrences_between(t0, t1) to cover the question from #153.

Or is there a better name for this?

occurrences_with_duration_between
occurrences_occurring_between
occurrences_intersecting_between
?

[seejohnrun]

Is this not occurring_between?

[seejohnrun]

My bad - I vote for occurrences_occurring_between

[avit]

@seejohnrun nope, that only returns a true or false, but the implementation is already all in there.

[avit]

It's a mouthful, but maybe it's the better name. I also thought we could go with simply:

schedule.occurring_between # => array
schedule.occurring_between? # => true

But, there's potential for confusion there... On a related note, in general I do find that "occurring at" has potential for confusion with "occurs at", although one's really about the duration, and the other about the occurrence start.

There might be a better word for this:

schedule.continuing_at?(t0) # was: occurring_at?
schedule.continuing_between(t0, t1) # was: occurring_between?
schedule.continuances_between(t0, t1) # new method

Dunno... it's more consistent at least.

[seejohnrun]

I like the occurring_between but there's definitely a potential for confusion we should try to avoid.

I'm not entirely sold on continuing yet, but could be swayed. I don't like how it doesn't describe the first or last occurrences well

[findchris]

👍 for occurring_between. I think the fear of the confusion is being overestimated. I like this interface:

schedule.occurring_between # => array
schedule.occurring_between? # => true

[coorasse]

did someone implemented this? Anyway having two methods occurs_between and occurring_between is really a bad and confusioning choice. I would prefer using a different and more meaningful word as interlap

[eremzeit]

I'm with @coorasse about the occurs_between and occurring_between. You pretty much have to go to the source to get an idea.

[avit]

@coorasse no this was not implemented yet. I ended up not needing it, and it would likely just create name confusion for everyone else without some good consensus.

[avit]

@eremzeit just to clarify, this is not the same as the two existing predicate methods occurs_between? and occurring_between? which you find in the source: this is proposing yet another similar method, but a poor choice of name.

maybe it's more obvious as an option: occurrences_between(go, stop, duration: true)

[naomiaro]

This seems like it could be of use. How about a method name of occurring_within(t0, t1) ?

[Chosko]

what about occurrences_intersecting(t0, t1) ?

[jopotts]

There's a pull request with this working already that simply opts for a new spans parameter on the enumerate_occurrences method.

@avit It would be good to get this merged into the master branch. It's in production and working well. Thanks.