Localization for rule descriptions

[mruokojo]

Hi!

I could not find any specs about how to localize rule string result. I need to localize for example rule string "Weekly, on tuesdays".

[seejohnrun]

Hey Mikko,

Internationalization has been a long dream of mine for the project - and a recent refactor has put me in a really good place to integrate it. I was waiting for someone to ask to build it, to avoid building things no one wanted.

I'll take this on as a feature branch, and update here as appropriate. Thanks!

JC

[masqita]

I'll ask now :-)

From what I see in the code, I'm guessing registering your own formatters that overrule the English ones would be the way to go (and this even works up to a certain point already). The question that lingers in the back of my head is whether that would actually work for romanic and/or slavic languages. They might structure their sentences in a different way. Not a problem we'll face at the moment (our app is Dutch and English), but other people using IceCube might run into issues. Mikko's probably Finnish, so he should be able to shed some light on this matter.

Providing a way to couple it into Rails i18n would be nice too (and is probably what most people will be looking for).

[bitboxer]

+1 for this!

[dgilperez]

+1 for this!

I'm willing to contribute with the spanish localization if you tell me how :)

[luisalima]

+1, willing to contribute with Portuguese localization.

Very nice, I would do the Germany locale.

[endymonium]

I'll also need localization quite soon ... I've got a very easy solution in mind: replacing of every string with I18n.translate, e.g.

builder.base = interval == 1 ? I18n.t('weekly') : "Every #{interval} #{I18n.t('weeks')}"

See also my fork at https://github.com/endymonium/ice_cube

If this is ok I'll go ahead and complete this for every string I find and create a pull request?

[seejohnrun]

I worry about how the builder will combine multiple rules if we just wrap strings like that

At the minimum, we'd need to wrap the whole string like I18n.t(:every_n_weeks, :interval => interval)

I have been working on the builder, it may need some refactoring in the future but for now it seems to be okay. Check out my fork, if you're interested, I'm keeping it up to date. I'll issue a pull request as soon as I get all the tests passing.

My skills are slightly overstretched when it comes to localising too complex sentences, particularly different genders of the days of the week in Portugese.

However, my fork joelmeyerhamme/ice_cube#international is nearly finished. So if anyone knows how to crack this nut, feel free to comment, fork or do whatever might help!

[avit]

Cheers @joelmeyerhamme, I'll have a look at this when I have some time.

[dgilperez]

Hi! How is this goodie going? Any help needed?

Indeed, help is totally needed. The locales are (almost) complete, however, I wasn't able to get around lists of rules. For example, in Portugese day names have different genders and cannot be used with the same article: "on friday and saturday" -- " na 5a feira e no sabado".

Though I can't solve this myself, I'll be happy to assist. Just run the tests to see what's missing.

[dgilperez]

@joelmeyerhamme I PR some changes to your fork with the spanish localization. The gender thing is tricky. Did you have a look at how does Rails or other proyects solve this?

From the spanish translation, we still need to sort out:

• Weekdays in spanish start on Monday, not Saturday.
• The ordinal form sounds a bit weird.

Some spanish-speaking one wants to have a look?

[XORwell]

i think @joelmeyerhamme did a good job @seejohnrun is it ready to get merged?
if its working it should get merged IMO - waiting until we have translations for all other (~6900) languages does not bring us further. i'm looking forward to use ice_cube with i18n support.

ping me if i can help with open (coding) action items.