Adding namespacing to Rule in Readme to make it easier to run examples#290
Merged
Conversation
Collaborator
There was a problem hiding this comment.
what's this one doing?
Contributor
Author
There was a problem hiding this comment.
Oops. That was going to grow into a 'require' because 1.day etc only works with rails helpers but then I went back to take it out and missed one.
Collaborator
There was a problem hiding this comment.
Cool - and thanks so much for the PR!
If we can get that fixed I'm excited to merge!
seejohnrun
added a commit
that referenced
this pull request
Aug 7, 2015
Adding namespacing to Rule in Readme to make it easier to run examples
Contributor
Author
|
Awesome! Thanks :) |
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While experimenting with this library with my team I ran into the inconvenience that some of the usages of Rule in the readme are namespaced to IceCube:: and some are not, so here is a PR. 👾