fix offset bug when base_interval_validation.type is not hourly#452
Conversation
| end | ||
| end | ||
|
|
||
| context 'when base interval validation type is not hourly' do |
There was a problem hiding this comment.
Could we describe the scenario instead of the implementation please?
Something like: "with an hour of day that is misaligned to the start time", or similar if I'm understanding the whole issue here. You can run rspec --format=doc on this file and see what makes sense here.
There was a problem hiding this comment.
Updated language somewhat. The more I dig into this, the more niche this bug seems.
- schedule with both weekly intervals and hour of day rules to trigger the
base_interval_validation.typemismatch - a
start_timethat is misaligned with thedayrule so that start_time modification due tospans: trueis not defaulted back tostart_time
I can perhaps nest more contexts if that would be preferred?
It's also a bit tricky as to where exactly this spec should exist. The change was made in hour_of_day, so I'm happy to relocate it there if that feels more relevant.
The discovery process was very much outside-in, so apologies for any extra confusion.
| context 'when base interval validation type is not hourly' do | ||
| let(:start_time) { Time.utc(2018, 8, 7, 7, 0, 0) } | ||
| let(:end_time) { Time.utc(2018, 8, 7, 15, 0, 0) } | ||
| let(:biweekly) { IceCube::Rule.weekly(2).day(:saturday).hour_of_day(10) } |
There was a problem hiding this comment.
Are both day and hour_of_day needed for this scenario? I'd like to keep this isolated to the single issue at hand if possible.
There was a problem hiding this comment.
Agreed on wanting to simplify the scenario. I was unable to reproduce this bug without both validation requirements also being present.
There was a problem hiding this comment.
If it only affects weekly schedules, then I think it belongs here.
avit
left a comment
avit
left a comment
There was a problem hiding this comment.
Looks great, thanks for digging into this!
| context 'when base interval validation type is not hourly' do | ||
| let(:start_time) { Time.utc(2018, 8, 7, 7, 0, 0) } | ||
| let(:end_time) { Time.utc(2018, 8, 7, 15, 0, 0) } | ||
| let(:biweekly) { IceCube::Rule.weekly(2).day(:saturday).hour_of_day(10) } |
There was a problem hiding this comment.
If it only affects weekly schedules, then I think it belongs here.
3 participants
bug described in #451