Implemented preliminary styling for native widgets.#102
Closed
Maldela wants to merge 5 commits into
Closed
Conversation
Member
|
Hey @Maldela, thank you for exploring this! I really appreciate the effort here! That said, I do not think we are yet ready to write code to implement this feature. There is a lot to consider, discuss, and design. As the contributing guide states, please get in touch! I'd love it if you joined our Zulip server and we started a conversation there. I really think code will be the easy part here. Your current approach is a very direct way of implementing support for styling, but it ties style properties to each particular widget in |
228cbf5 to
634f13d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was playing around with styling the different iced examples and this is what I came up with.
To make this work I had to extend some of the widgets and change the view function of the Application and Sandbox traits to supply an ApplicationStyle object which can be used to construct widgets. This work is by far not finished yet. My next steps would be adding the possibility to load platform specific plugins to have a native look across different platforms and splitting the ApplicationStyle object into some sort of color palette to theme custom widgets and a set of styles for the built in widgets.
Consider this more a RFC then a PR. I just wanted to get some feedback about my approach so far.