Mesh2D primitive for rendering arbitrary geometry in iced_wgpu#140
Merged
Conversation
artursapek
force-pushed
the
artur/canvas
branch
from
5a95792 to
8d1e2f1
Compare
artursapek
force-pushed
the
artur/canvas
branch
from
8d1e2f1 to
0d620b7
Compare
artursapek
changed the title
hecrj
approved these changes
Jan 2, 2020
Member
There was a problem hiding this comment.
This is great. It lays the foundations to implement a Canvas2D widget (see #32) and simpler widgets, like a color picker. Thank you! 🎉
I have renamed Geometry2D to Mesh2D and moved the types to iced_wgpu, as I think these are very basic GPU primitives and we are only using them in iced_wgpu::Primitive for now. I have also wrapped the Mesh2D in an Arc, so widgets can cache meshes if they need to.
Let me know what you think, and we can merge this!
hecrj
changed the title
iced_wgpu
Contributor
Author
|
@hecrj those changes seem great to me. Thanks for taking it to the finish line. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.