Customize Checkbox#192
Merged
Merged
Conversation
clarkmoody
commented
Feb 17, 2020
Comment on lines
+59
to
+62
| size: 20, | ||
| width: Length::Shrink, | ||
| spacing: 15, | ||
| text_size: 20, |
Contributor
Author
There was a problem hiding this comment.
Would be really nice to pull these from an underlying renderer.
Member
There was a problem hiding this comment.
Yes, I think we can add these to the Renderer trait using associated constants.
hecrj
approved these changes
Feb 18, 2020
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I have moved the constants to checkbox::Renderer and did something similar with text::Renderer so we can reuse the default text size instead of redefining it.
I think we can merge this. Let me know.
Contributor
Author
|
Those changes look good to me! Let's merge.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
size,spacing, andtext_sizeproperties to Checkbox.