Add example for download with progress tracking#232
Merged
hecrj merged 6 commits intoMar 23, 2020
Conversation
Songtronix
force-pushed
the
songtronix/add-download-example
branch
from
18ac2ed to
f97e49f
Compare
Folyd
approved these changes
Mar 23, 2020
Folyd
approved these changes
Mar 23, 2020
Songtronix
commented
Mar 23, 2020
Songtronix
force-pushed
the
songtronix/add-download-example
branch
from
f97e49f to
fff333f
Compare
Contributor
Author
|
If someone has an idea on how to integrate proper error handling into that I am surely interested! |
Member
|
I am working on an improved version. |
- Use `reqwest` with `Response::chunk` to notify progress. - Turn example state into an enum
Member
|
I have updated the example to use I also changed the example code a bit and renamed some things. Let me know what you think! |
Contributor
Author
|
I love it! 💙 |
hecrj
changed the title
hecrj
approved these changes
Mar 23, 2020
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
Awesome! I think we can merge this then.
Thank you for putting this together! 🍻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.