Layers#235
Conversation
|
Hey, thanks for taking a shot at this! I appreciate the effort! I see you have tackled layering at the rendering level, but the main challenge with layers is related to event processing! For instance, when displaying a button on top of another interactive element the events should be captured by the button and not by the element behind it. This is the main challenge that we need to solve elegantly. I talked about this topic in #30 and discussed it in our Zulip server very recently. We are not ready to write code for this yet, but we are getting close! Before tackling an important feature like this one, I'd really prefer to hear from you first! As the It is very hard to accept a solution to a problem that we have been discussing for a while without much context. Specifically, there are two very important questions that we'd need to answer (extracted from
These questions tend to be answered organically with collaboration and discussion, ideally before a full implementation! |
|
Sorry hadn't noticed the Contributing guide and didn't think of event processing. Maybe I should close this PR what is your opinion? |
No worries! Thank you for spending time working on this 🙇♂️
I don't mind keeping it open until we settle on a design. I think there are some interesting ideas here (I like the relative Please, feel free to join the discussion! |
This PR aims to implement layers.
The way I did is to have the layering be relative to the last widget on the same level so for example a column with two images overlapping, if the
Depthis setNoneon both then with will be order dependent, if theDepthis set asAboveon the first then it will be order dependent, if it's set on the second one then the second image will be displayed on top, if the first is set toBelowthen the first will be displayed, if it's set on the second then it's order dependent. An exception is theTopmostwhich is global.It might not be the proper way to implement so I'm available to change it