Skip to content

#321 Fix async examples by feature-gating Command implementations + A…#322

Merged
hecrj merged 3 commits into
iced-rs:masterfrom
AlisCode:aliscode/321/fix-async-examples
Apr 25, 2020
Merged

#321 Fix async examples by feature-gating Command implementations + A…#322
hecrj merged 3 commits into
iced-rs:masterfrom
AlisCode:aliscode/321/fix-async-examples

Conversation

@AlisCode
Copy link
Copy Markdown
Contributor

Fixes #321 .

  • Fixes broken async examples by feature-gating Command methods that required Send on wasm32, causing conflicts.
  • Adds pokedex example in CI so that at least one async example is runned on CI.

AlisCode and others added 3 commits April 25, 2020 02:03
@hecrj hecrj added the bug Something isn't working label Apr 25, 2020
@hecrj hecrj added this to the 0.2.0 milestone Apr 25, 2020
Copy link
Copy Markdown
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you 🎉

@hecrj hecrj merged commit f9bfa82 into iced-rs:master Apr 25, 2020
hecrj added a commit that referenced this pull request Apr 26, 2020
#321 Fix async examples by feature-gating Command implementations + A…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Async Examples are broken on wasm32 backend

2 participants