document that img handle constructors guess fmt#324
Merged
Conversation
ethanpailes
force-pushed
the
document-image-format-guessing
branch
from
452fc8c to
2a73990
Compare
This patch documents the fact that a couple of the image handle constructors know how to guess the image format based on the data that they are provided. I had to dig through `iced` sources until I discovered that those routines ultimately boil down to stuff like [image::load_from_memory][1] from the `image` crate, so I thought I would save others the trouble of doing the same reverse-engineering [1]: https://docs.rs/image/0.23.4/image/fn.load_from_memory.html
ethanpailes
force-pushed
the
document-image-format-guessing
branch
from
2a73990 to
da2ab42
Compare
hecrj
approved these changes
Apr 27, 2020
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
Thank you.
This depends mainly on the renderer implementation. However, we will most likely move image::Handle and svg::Handle to iced_wgpu soon.
Therefore, I believe we can merge this.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch documents the fact that a couple of the image
handle constructors know how to guess the image format based
on the data that they are provided.
I had to dig through
icedsources until I discovered that thoseroutines ultimately boil down to stuff like image::load_from_memory
from the
imagecrate, so I thought I would save others the troubleof doing the same reverse-engineering