Improvement/58/feature gate font kit#370
Merged
hecrj merged 2 commits intoJun 1, 2020
Merged
Conversation
azriel91
force-pushed
the
improvement/58/feature-gate-font-kit
branch
3 times, most recently
from
5ebef99 to
df216d4
Compare
hecrj
requested changes
May 30, 2020
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
Looks great! This is exactly what I had in mind 😄
Just a couple of details and we can merge it.
azriel91
force-pushed
the
improvement/58/feature-gate-font-kit
branch
from
df216d4 to
86f0e3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #58.
I thought
icedwasn't working when nothing was showing up in the examples, and it happened to be #199 / #270 / #351. Should've searched issues earlier.Successor to #364 -- couldn't reopen it after deleting the branch unfortunately.
I'm not sure whether to choose
-or_between feature words, since there's a"glow_canvas"feature in the top levelCargo.toml.I've tested this using the
custom_widgetexample for bothiced_wgpuandiced_glow. Foriced_glowI disabled default features fromicedinexamples/custom_widget/Cargo.toml, and then running: