Add custom window background/clear color (incl. transparency) support, fixes #272#371
Merged
Merged
Conversation
…fixes iced-rs#272 wgpu would currently ignore the alpha: gfx-rs/wgpu#687 glow (and naively patched wgpu) requires premultiplied alpha, so if you don't multiply the RGB by the A right now, the semi-transparent color would be wrong (too bright). winit with_transparent doesn't seem necessary.
hecrj
approved these changes
Jun 1, 2020
Member
hecrj
left a comment
There was a problem hiding this comment.
At the very least, this adds support for changing the opaque background color.
We can iterate further to properly support transparency. Thanks!
Member
|
Hmm... After thinking a bit more about it, I believe the background color should be able to change at runtime. I imagine we could add it as an additional |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wgpu would currently ignore the alpha: gfx-rs/wgpu#687
glow (and naively patched wgpu) requires premultiplied alpha, so if you don't multiply the RGB by the A right now, the semi-transparent color would be wrong (too bright).
winit with_transparent doesn't seem necessary — on wayland at least.
for testing:
Screenshot showing both patched wgpu and glow with the same too-bright color (this is not how 0.1,0.2,0.3 is supposed to look like) as a result of not premultiplying alpha:
Of course for
Color::TRANSPARENTeverything is fine.