Skip to content

Upgrade glam to 0.9 & use glam's Mat4 ortho rh gl.#482

Merged
hecrj merged 2 commits into
iced-rs:masterfrom
bitshifter:glam-0.9
Aug 17, 2020
Merged

Upgrade glam to 0.9 & use glam's Mat4 ortho rh gl.#482
hecrj merged 2 commits into
iced-rs:masterfrom
bitshifter:glam-0.9

Conversation

@bitshifter
Copy link
Copy Markdown
Contributor

Hi there, glam 0.8 to 0.9 was a potentially breaking change so I've been trying to upgrade people. In Iced though there was no breakage.

Copy link
Copy Markdown
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I noticed the Y axis was inverted after your changes to Transformation::orthographic. We want Y to increase downwards from the top-left corner of the window.

I believe I fixed it in 02ca90a. Let me know!

@hecrj hecrj added the improvement An internal improvement label Aug 17, 2020
@hecrj hecrj added this to the 0.2.0 milestone Aug 17, 2020
@bitshifter
Copy link
Copy Markdown
Contributor Author

Ah whoops, I had it working then inverted it to check I was actually changing the right transform then forgot to change it back before I made the PR. I'm on my phone but I think that looks right if you've just switched top and bottom.

@hecrj
Copy link
Copy Markdown
Member

hecrj commented Aug 17, 2020

Awesome. Thank you again for the PR and also for your work on glam!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement An internal improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants