Skip to content

Remove outdated Fill comment for Column and Row#545

Merged
hecrj merged 3 commits into
iced-rs:masterfrom
MonliH:master
Oct 17, 2020
Merged

Remove outdated Fill comment for Column and Row#545
hecrj merged 3 commits into
iced-rs:masterfrom
MonliH:master

Conversation

@MonliH
Copy link
Copy Markdown
Contributor

@MonliH MonliH commented Oct 1, 2020

This PR makes the default width Length::Fill for the column widget.
Fixes #544.

@hecrj
Copy link
Copy Markdown
Member

hecrj commented Oct 3, 2020

Hey, thanks!

I changed the behavior from Fill to Shrink in #139, but I forgot to update the documentation 😅 We should fix that instead!

@MonliH
Copy link
Copy Markdown
Contributor Author

MonliH commented Oct 3, 2020

Oh, awesome! I'll document it then 😄.

@MonliH
Copy link
Copy Markdown
Contributor Author

MonliH commented Oct 3, 2020

I've documented this behaviour in the Column and Row widget, please let me know if I missed any other widgets that are out of date.

Comment thread native/src/widget/column.rs Outdated
@MonliH MonliH changed the title Make column fill container - satify documented behaviour Document widget fill behaviour Oct 8, 2020
@MonliH MonliH changed the title Document widget fill behaviour Document the widget fill behaviour Oct 8, 2020
@hecrj hecrj added the improvement An internal improvement label Oct 17, 2020
@hecrj hecrj added this to the 0.2.0 milestone Oct 17, 2020
@hecrj hecrj changed the title Document the widget fill behaviour Remove outdated Fill comment for Column and Row Oct 17, 2020
Copy link
Copy Markdown
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement An internal improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Column.width = Shrink by default

2 participants