Skip to content

update resvg to latest, same with guillotiere#573

Closed
aentity wants to merge 1 commit into
iced-rs:masterfrom
aentity:update_resvg
Closed

update resvg to latest, same with guillotiere#573
aentity wants to merge 1 commit into
iced-rs:masterfrom
aentity:update_resvg

Conversation

@aentity
Copy link
Copy Markdown
Contributor

@aentity aentity commented Oct 22, 2020

Hello, also to update resvg, which removes old deflate and old png, and many other deps in a tree.

@aentity
Copy link
Copy Markdown
Contributor Author

aentity commented Oct 22, 2020

Oh no, it looks that resvg has removed raqote and uses a "tiny skia" which is native build? maybe it's not good, i don't know.

@hecrj
Copy link
Copy Markdown
Member

hecrj commented Oct 29, 2020

Yeah, the dependencies of resvg have grown considerably. We may consider using an updated version once tiny-skia matures or whenever we implement a Skia renderer.

In any case, thanks for taking a shot at this. Closing for now!

@hecrj hecrj closed this Oct 29, 2020
@hecrj hecrj added the improvement An internal improvement label Oct 29, 2020
@hecrj hecrj added this to the 0.2.0 milestone Oct 29, 2020
@hecrj hecrj mentioned this pull request Nov 10, 2020
@valpackett
Copy link
Copy Markdown
Contributor

Switched to resvg from git in my fork now: valpackett@a2d07cb (tiny-skia is all-Rust already)

It outputs RGBA instead of BGRA.. for now I just added the conversion right there using image, but it would be much better to "convert" in the fragment shader.

Code size of rustybuzz+tiny_skia+usvg+resvg in release mode is considerable, though wgpu+wgpu_core+naga+gfx_backend_vulkan+ash is still bigger :)

 File  .text     Size Crate
 9.4%  22.7% 812.1KiB wgpu
 3.9%   9.4% 337.4KiB std
 3.1%   7.4% 266.0KiB rustybuzz
 3.0%   7.3% 260.9KiB tiny_skia
 2.2%   5.3% 189.0KiB usvg
 2.1%   5.0% 179.4KiB iced_wgpu
 1.9%   4.6% 166.1KiB naga
 1.7%   4.0% 144.3KiB wgpu_core
 1.3%   3.1% 111.8KiB smithay_client_toolkit
 1.0%   2.5%  90.9KiB resvg
 0.9%   2.3%  82.1KiB ttf_parser
 0.9%   2.1%  75.0KiB wayland_client
 0.7%   1.8%  63.1KiB gfx_backend_vulkan

@hecrj
Copy link
Copy Markdown
Member

hecrj commented Nov 26, 2020

@myfreeweb Cool! Yeah, I saw the announcement of tiny-skia a while ago.

We are just waiting for a new resvg release at this point. Feel free to open a PR!

@hecrj hecrj mentioned this pull request Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement An internal improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants