Generic Element Content in Pane Grid TitleBar#657
Merged
hecrj merged 4 commits intoDec 22, 2020
Conversation
This is no longer necessary, as we do not render text directly anymore.
hecrj
approved these changes
Dec 22, 2020
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
Looks great! It simplifies a bunch of code, as users can leverage the Text widget and, therefore, we can avoid rendering the title manually.
Thanks 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the
TitleBarmore flexible by replacing the basic string + size with a genericElement.Not quite sure if I've connected all the dots, especially regarding events/interactions on the elements within the title content.
Upgraded the example program to have a colored Pane ID, showing off a
Rowcontaining twoTextelements.